scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-07 09:05:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

don't use top-level execute for Count(Distinct()) aggregates

Browse source 
This is the only call to top-level execute, as opposed to
executeCall, that we make anywhere. I'm trying to clean up this
logic and I don't want a special case.

Note the change from an empty shard list to specifying the shard
list we already had, which I think is logically correct here,
but this might actually be a debatable point; it's possible that
we really do want to farm that out with an empty shard list,
so execute will find one, except that I don't think it *actually*
works for us, because the execute is still running on this index,
and presumably getting the shard list we started with. Unless
this is vulnerable to "shard list can become stale from previous
writes". So this passes tests but I'm not 100% sure on the shard
decision there.
This commit is contained in:
Seebs 2023-01-20 13:01:24 -06:00
parent 7386f13159
commit 2862680d32
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
executor.go
View file

@ -3181,11 +3181,11 @@ func (e *executor) executeGroupBy(ctx context.Context, qcx *Qcx, index string, c
}
opt.PreTranslated = true
aggregateCount, err := e.execute(ctx, qcx, index, &pql.Query{Calls: []*pql.Call{countDistinctIntersect}}, []uint64{}, opt)
aggregateCount, err := e.executeCall(ctx, qcx, index, countDistinctIntersect, shards, opt)
if err != nil {
return nil, err
}
results[n].Agg = int64(aggregateCount[0].(uint64))
results[n].Agg = int64(aggregateCount.(uint64))
}
}