From 63c3a8b76192cba013e02dd886766ea6b16e7ca6 Mon Sep 17 00:00:00 2001
From: Matthew Jaffee <jaffee@pilosa.com>
Date: Tue, 1 Mar 2022 13:51:13 -0600
Subject: [PATCH 1/2] add "needs: []" to go tests race to make it start
 immediately

also move race tests to a special "nonblocking" stage that is after
everything else, so they don't block anything else from starting
---
 .gitlab/.gitlab-ci.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.gitlab/.gitlab-ci.yml b/.gitlab/.gitlab-ci.yml
index d2c78d989..31f8de039 100644
--- a/.gitlab/.gitlab-ci.yml
+++ b/.gitlab/.gitlab-ci.yml
@@ -14,6 +14,7 @@ stages:
   - gauntlet
   - performance
   - post build
+  - nonblocking
 
 smoke build:
   image: golang:$GOVERSION
@@ -84,11 +85,12 @@ run go tests:
     - aws
 
 run go tests race:
-  stage: test
+  stage: nonblocking # don't let this job block any other jobs because it takes much longer than the other tests.
   image: golang:$GOVERSION
   rules:
     - if: '$CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web"'
   retry: 1
+  needs: [] # don't wait to start running this.
   script:
     - echo "Running featurebase race tests..."
     - go test -race -v -timeout=90m ./...
@@ -101,7 +103,7 @@ run go tests shardwidth22:
   rules:
     - if: '$CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web"'
   script:
-    - echo "Running featurebase race tests..."
+    - echo "Running featurebase shardwidth22 tests..."
     - go test -timeout=30m -tags=shardwidth22 ./...
   tags:
     - aws

From 0dc5aed8d77476a4c8b59704352b5de4de07d275 Mon Sep 17 00:00:00 2001
From: Matthew Jaffee <jaffee@pilosa.com>
Date: Tue, 1 Mar 2022 16:32:53 -0600
Subject: [PATCH 2/2] add "go mod tidy" CI check

pulled this from IDK... we just had an issue where we had an unused
dep in go.mod.
---
 .gitlab/.gitlab-ci.yml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/.gitlab/.gitlab-ci.yml b/.gitlab/.gitlab-ci.yml
index 31f8de039..a0b2ca8b3 100644
--- a/.gitlab/.gitlab-ci.yml
+++ b/.gitlab/.gitlab-ci.yml
@@ -36,6 +36,15 @@ golangci-lint:
     - echo "Checking for issues in new code"
     - golangci-lint run
 
+go mod tidy:
+  stage: lint
+  image: golang:$GOVERSION
+  rules:
+    - if: '$CI_COMMIT_TAG == null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")'
+  script:
+    - go mod tidy
+    - git diff --exit-code -- go.mod go.sum
+
 build lattice:
   stage: test
   image: node:14