Fix inmem read only translation bug

This commit is contained in:
Ben Johnson 2019-12-31 08:49:32 -07:00
parent 2f76283f03
commit 1b068f75a8

View file

@ -286,10 +286,6 @@ func (s *InMemTranslateStore) SetReadOnly(v bool) {
func (s *InMemTranslateStore) TranslateKey(key string) (uint64, error) {
s.mu.Lock()
defer s.mu.Unlock()
if s.readOnly {
return 0, nil
}
return s.translateKey(key)
}
@ -299,10 +295,6 @@ func (s *InMemTranslateStore) TranslateKeys(keys []string) (_ []uint64, err erro
s.mu.Lock()
defer s.mu.Unlock()
if s.readOnly {
return nil, nil
}
ids := make([]uint64, len(keys))
for i := range keys {
if ids[i], err = s.translateKey(keys[i]); err != nil {
@ -316,6 +308,8 @@ func (s *InMemTranslateStore) translateKey(key string) (_ uint64, err error) {
// Return id if it has been added.
if id, ok := s.idsByKey[key]; ok {
return id, nil
} else if s.readOnly {
return 0, nil
}
// Generate a new id and update db.