scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #803 from molecula/fgen_refined

Browse source 
refine our f.gen nil handling to support blue/green
This commit is contained in:
jaten-molecula 2020-09-04 18:52:32 -04:00 • committed by GitHub
commit 1994560cf6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
fragment.go
View file

@ -638,8 +638,11 @@ func (f *fragment) setBit(tx Tx, rowID, columnID uint64) (changed bool, err erro
if f.gen != nil {
err = f.gen.Transaction(wp, doSetFunc)
} else {
panic("internal error: f.gen was nil. should never happen under roaring b/c storage should be open")
//err = doSetFunc()
if tx.Type() == RoaringTxn {
panic("internal error: f.gen was nil. should never happen under roaring b/c storage should be open")
}
// else blue green or transactional backend. Just do it.
err = doSetFunc()
}
return changed, err
}
@ -2342,8 +2345,11 @@ func (f *fragment) importPositions(tx Tx, set, clear []uint64, rowSet map[uint64
if f.gen != nil {
err = f.gen.Transaction(wp, doFunc)
} else {
panic("internal error: 2nd place, f.gen was nil. should never happen under roaring b/c storage should be open")
//err = doFunc()
if tx.Type() == RoaringTxn {
panic("internal error: 2nd place, f.gen was nil. should never happen under roaring b/c storage should be open")
}
// else blue green or transactional backend. Just do it.
err = doFunc()
}
if err != nil {