From 37b55c190fce8c8c332c5f98722250ae4aa625bc Mon Sep 17 00:00:00 2001 From: Seebs Date: Tue, 7 Sep 2021 14:06:23 -0500 Subject: [PATCH] drop rbf_bolt tests from CI The rbf_bolt tests are unusually expensive, partially because they're run with the race detector on, but also because it's basically running two copies of all the tests and comparing them... But they haven't detected anything in ages, because the RBF stuff is now pretty stable, and those tests take about twice as long as anything else in our testing, and thus impede our workflow noticably for little-to-no return. We might some day want to fully remove them, but for now, just taking them out of CI should streamline our workflows a bit. --- .circleci/config.yml | 2 +- Makefile | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a861a83fc..0ae2f1f43 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -272,7 +272,7 @@ workflows: - setup matrix: parameters: - test_make_target: ["test-race", "test-txstore-rbf_bolt"] + test_make_target: ["test-race"] - test: name: test-shardwidth-22 context: molecula diff --git a/Makefile b/Makefile index 2c2ac0456..6fb679f91 100644 --- a/Makefile +++ b/Makefile @@ -341,6 +341,9 @@ install-gometalinter: test-txstore-rbf: PILOSA_STORAGE_BACKEND=rbf $(MAKE) testv-race +# WARNING: This feature is no longer being tested regularly in CI. The test is +# very slow and very expensive, and we're not sure it actually provides useful +# information now. test-txstore-rbf_bolt: PILOSA_STORAGE_BACKEND=rbf_bolt $(MAKE) testv-race