scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-07 17:15:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove unecessary span from executor tracing

Browse source
This commit is contained in:
Matt Jaffee 2019-11-20 16:59:20 -06:00
parent 60397d3e8f
commit 114c1a9df8
No known key found for this signature in database
GPG key ID: 08A3DFFF987B11BF
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
executor.go
View file

@ -1068,27 +1068,22 @@ func (e *executor) executeSumCountShard(ctx context.Context, index string, c *pq
fieldName, _ := c.Args["field"].(string)
fragspan, ctx := tracing.StartSpanFromContext(ctx, "Executor.executeSumCountShard_gettingFragment")
field := e.Holder.Field(index, fieldName)
if field == nil {
fragspan.Finish()
return ValCount{}, nil
}
bsig := field.bsiGroup(fieldName)
if bsig == nil {
fragspan.Finish()
return ValCount{}, nil
}
fragment := e.Holder.fragment(index, fieldName, viewBSIGroupPrefix+fieldName, shard)
if fragment == nil {
fragspan.Finish()
return ValCount{}, nil
}
fragspan.Finish()
sumspan, ctx := tracing.StartSpanFromContext(ctx, "Executor.executeSumCountShard_fragment.sum")
sumspan, _ := tracing.StartSpanFromContext(ctx, "Executor.executeSumCountShard_fragment.sum")
defer sumspan.Finish()
vsum, vcount, err := fragment.sum(filter, bsig.BitDepth)
if err != nil {