scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-10-07 19:37:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not reuse error object (data race)

Browse source
This commit is contained in:
Cody Soyland 2020-04-16 17:08:24 -05:00
parent e4cd1b8871
commit 1058440cfe
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
server/server.go
View file

@ -416,8 +416,9 @@ func (m *Command) setupNetworking() error {
}
// setupLogger sets up the logger based on the configuration.
func (m *Command) setupLogger() (err error) {
func (m *Command) setupLogger() error {
var f *reopen.FileWriter
var err error
if m.Config.LogPath == "" {
m.logOutput = m.Stderr
} else {
@ -438,7 +439,7 @@ func (m *Command) setupLogger() (err error) {
go func() {
for {
// duplicate stderr onto log file
err = m.dup(int(f.Fd()), int(os.Stderr.Fd()))
err := m.dup(int(f.Fd()), int(os.Stderr.Fd()))
if err != nil {
m.logger.Printf("syscall dup: %s\n", err.Error())
}