scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-10-07 03:17:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cache result of marshalling import-was-OK message

Browse source 
This message gets generated millions of times and it's unchanging
for the life of the program, and small.
This commit is contained in:
Seebs 2020-04-03 13:16:12 -05:00
parent 79940cf077
commit 0ddc968001
1 changed files with 13 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
http/handler.go
View file

@ -31,6 +31,7 @@ import (
"runtime/debug"
"strconv"
"strings"
"sync"
"time"
"github.com/gorilla/handlers"
@ -122,8 +123,18 @@ func OptHandlerCloseTimeout(d time.Duration) handlerOption {
}
}
var makeImportOk sync.Once
var importOk []byte
// NewHandler returns a new instance of Handler with a default logger.
func NewHandler(opts ...handlerOption) (*Handler, error) {
makeImportOk.Do(func() {
var err error
importOk, err = proto.DefaultSerializer.Marshal(&pilosa.ImportResponse{Err: ""})
if err != nil {
panic(fmt.Sprintf("trying to cache import-OK response: %v", err))
}
})
handler := &Handler{
logger: logger.NopLogger,
closeTimeout: time.Second * 30,
@ -1392,15 +1403,8 @@ func (h *Handler) handlePostImport(w http.ResponseWriter, r *http.Request) {
}
}
// Marshal response object.
buf, e := proto.DefaultSerializer.Marshal(&pilosa.ImportResponse{Err: ""})
if e != nil {
http.Error(w, "marshal import response", http.StatusInternalServerError)
return
}
// Write response.
_, err = w.Write(buf)
_, err = w.Write(importOk)
if err != nil {
h.logger.Printf("writing import response: %v", err)
}
@ -1911,15 +1915,8 @@ func (h *Handler) handlePostImportColumnAttrs(w http.ResponseWriter, r *http.Req
return
}
// Marshal response object.
buf, e := proto.DefaultSerializer.Marshal(&pilosa.ImportResponse{Err: ""})
if e != nil {
http.Error(w, "marshal import-column-attrs response", http.StatusInternalServerError)
return
}
// Write response.
_, err = w.Write(buf)
_, err = w.Write(importOk)
if err != nil {
h.logger.Printf("writing import-column-attrs response: %v", err)
}