scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 02:44:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

enable staticcheck in ci; remove dead code (#2281)

Browse source
This commit is contained in:
tgruben 2022-11-07 13:45:19 -06:00 • committed by GitHub
parent 0aa5efcc51
commit 0d6a92aeaf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.golangci.yml
View file

@ -12,6 +12,7 @@ linters:
enable:
- govet
- gofmt
- staticcheck
enable-all: false
disable-all: true

3
api/client/grpc.go
View file

@ -12,6 +12,7 @@ import (
"google.golang.org/grpc"
"google.golang.org/grpc/connectivity"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/credentials/insecure"
)
const maxMsgSize = 1024 * 1024 * 100 // 100 megs ought to be enough for anybody!
@ -63,7 +64,7 @@ func (c *GRPCClient) resetConn() error {
creds := credentials.NewTLS(c.tlsConfig)
opts = append(opts, grpc.WithTransportCredentials(creds))
} else {
opts = append(opts, grpc.WithInsecure())
opts = append(opts, grpc.WithTransportCredentials(insecure.NewCredentials()))
}
opts = append(opts, grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(maxMsgSize)))

10
test/cluster.go
View file

@ -488,16 +488,6 @@ func (c *ShareableCluster) Start() error {
// Close stops a Cluster
func (c *ShareableCluster) Close() error {
if c.shared {
for i := range c.Nodes {
holder := c.GetHolder(i)
indexes := holder.Indexes()
var indexNames []string
for _, idx := range indexes {
indexNames = append(indexNames, idx.Name())
}
}
}
for i, cc := range c.Nodes {
if err := cc.Close(); err != nil {
return errors.Wrapf(err, "stopping server %d", i)