scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-05 08:10:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

bug in CountRange

Browse source
This commit is contained in:
Todd Gruben 2017-06-16 16:27:54 -05:00 • committed by Matt Jaffee
parent f334d122c8
commit 02cba542e8
2 changed files with 42 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
roaring/roaring.go
View file

@ -196,7 +196,7 @@ func (b *Bitmap) CountRange(start, end uint64) (n uint64) {
j := search64(b.keys, highbits(end))
// If range is entirely in one container then just count that range.
if i > 0 && i == j {
if i >= 0 && i == j {
return uint64(b.containers[i].countRange(lowbits(start), lowbits(end)))
}

43
roaring/roaring_test.go
View file

@ -127,6 +127,29 @@ func TestBitmap_Max(t *testing.T) {
}
}
}
func TestBitmap_CountRange(t *testing.T) {
bm0 := roaring.NewBitmap(0, 2683177)
for i := uint64(628); i < 2683301; i++ {
bm0.Add(i)
}
bm0.Add(2683307)
if n := bm0.CountRange(1, 2683311); n != 2682674 {
t.Fatalf("unexpected n: %d", n)
}
if n := bm0.CountRange(2683177, 2683310); n != 125 {
t.Fatalf("unexpected n: %d", n)
}
if n := bm0.CountRange(2683301, 3000000); n != 1 {
t.Fatalf("unexpected n: %d", n)
}
if n := bm0.CountRange(0, 1); n != 1 {
t.Fatalf("unexpected n: %d", n)
}
}
func TestBitmap_Intersection(t *testing.T) {
bm0 := roaring.NewBitmap(0, 2683177)
@ -140,6 +163,16 @@ func TestBitmap_Intersection(t *testing.T) {
t.Fatalf("unexpected n: %d", n)
}
}
func TestBitmap_Intersection_Empty(t *testing.T) {
bm0 := roaring.NewBitmap(0, 2683177)
bm1 := roaring.NewBitmap()
result := bm0.Intersect(bm1)
if n := result.Count(); n != 0 {
t.Fatalf("unexpected n: %d", n)
}
}
func TestBitmap_Difference(t *testing.T) {
@ -149,11 +182,18 @@ func TestBitmap_Difference(t *testing.T) {
bm1.Add(i)
}
result := bm0.Difference(bm1)
//expect to have just 0
if n := result.Count(); n != 1 {
t.Fatalf("unexpected n: %d", n)
}
}
func TestBitmap_Difference_Empty(t *testing.T) {
bm0 := roaring.NewBitmap(0, 2683177)
bm1 := roaring.NewBitmap()
result := bm0.Difference(bm1)
if n := result.Count(); n != 2 {
t.Fatalf("unexpected n: %d", n)
}
}
func TestBitmap_Union(t *testing.T) {
bm0 := roaring.NewBitmap(0, 1000001, 1000002, 1000003)
@ -417,7 +457,6 @@ func testBitmapQuick(t *testing.T, n int, min, max uint64) {
})
}
func TestBitmap_Marshal_Quick_Array1(t *testing.T) { testBitmapMarshalQuick(t, 1000, 1000, 2000, false) }
func TestBitmap_Marshal_Quick_Array2(t *testing.T) { testBitmapMarshalQuick(t, 10000, 0, 1000, false) }
func TestBitmap_Marshal_Quick_Bitmap1(t *testing.T) { testBitmapMarshalQuick(t, 10000, 0, 10000, false) }