mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-07 08:27:12 +00:00
8d14b54994
Addresses a Copilot review comment on #653. The source array is runtime data, usually produced by a model, so its length is not something a workflow author reviewed. Two changes, so an over-long array degrades into a clear error rather than memory pressure. Cap the item count at 1000. Above that the stage fails deterministically before `parallel.started`, alongside the other for_each contract violations, and the message says how to reduce the array. Fork the parent context inside the branch task, after it acquires a `max_parallel` slot, instead of at dispatch time. Live context copies now track `max_parallel` rather than item count. Only the branch's own preamble entry is moved into the task, so the shared stash is not cloned per branch either. The reviewer also suggested replacing spawn-all with `max_parallel` workers pulling from a queue. Not done here: with the fork deferred, a pending task holds little beyond its item, and reshaping the dispatch loop would change cancellation and scope-reservation ordering, which deserves its own review. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fabro-acp | ||
| fabro-agent | ||
| fabro-automation | ||
| fabro-checkpoint | ||
| fabro-dump | ||
| fabro-environment | ||
| fabro-github | ||
| fabro-graphviz | ||
| fabro-hooks | ||
| fabro-install | ||
| fabro-interview | ||
| fabro-llm | ||
| fabro-manifest | ||
| fabro-mcp | ||
| fabro-mcp-store | ||
| fabro-sandbox | ||
| fabro-slack | ||
| fabro-store | ||
| fabro-tool | ||
| fabro-tracker | ||
| fabro-validate | ||
| fabro-variable | ||
| fabro-workflow | ||