Bryan Helmkamp fb04e17329 refactor(settings): stage 6.3b delete legacy flat Settings struct ... Deletes `fabro_types::Settings` — the ~65-field legacy flat view that has been read-only since Stage 6.1 migrated all production read sites to the v2 `SettingsFile`. The last remaining readers all fall out of this commit: - `fabro-server/src/demo/mod.rs` — the two demo settings fixtures (`runs::settings()` and `settings::server_settings()`) are rewritten as `serde_json::json!(...)` literals in the v2 `SettingsFile` shape. They produce the same wire bytes as the real handlers now return, so the demo page keeps rendering identically. - `fabro-server/src/lib.rs::server_config` — drops the `pub use fabro_types::Settings` re-export. Only the inner `fabro_types::settings::server::*` module (still around until the full runtime-type cleanup) remains. - `fabro-server/tests/it/openapi_conformance.rs` — drops the `server_settings_keys_match_openapi_spec` schema-drift test and all of its legacy type imports. The new freeform-object DTO in the spec (`type: object, additionalProperties: true`) has no `properties` to diff against, so the test was already a no-op. Leaves `all_spec_routes_are_routable` in place. - `fabro-store/src/run_state.rs` — test fixture was building a `Settings::default()` JSON payload; switched to `SettingsFile::default()`. - `fabro-types/src/run_event/mod.rs` — two `EventBody::RunCreated` round-trip tests were constructing `Settings::default()`; switched to `SettingsFile::default()`. - `fabro-workflow/tests/it/integration.rs` — the two `hook_toml_*_parsing` tests decoded top-level `[[hooks]]` into a legacy `Settings`. That parse path was removed in Stage 6.1; the tests are deleted and replaced with a comment pointing at the v2 `settings::v2::tree::tests` fixtures that cover the same ground. The legacy flat struct's module-level doc comment in `settings/mod.rs` is updated to explain the transitional runtime shapes that still live under `hook`, `mcp`, `project`, `run`, `sandbox`, `server`, and `user` — a follow-up pass will either promote them into their consumer crates or inline them at the call sites so the whole `settings/*.rs` file set can go away and 6.5b flattening can happen. 3,758 workspace tests pass. `cargo fmt --check --all` and `cargo clippy --workspace -- -D warnings` are clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>		2026-04-09 17:32:03 -04:00
..
crates	refactor(settings): stage 6.3b delete legacy flat Settings struct	2026-04-09 17:32:03 -04:00
packages/fabro-api-client	refactor(api): stage 6.6 collapse settings DTOs to freeform v2 shape	2026-04-09 17:04:33 -04:00