mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-08-28 05:27:41 +00:00
fae39d9fd6
Second pass, from the remaining review findings. - Wrap the stall watchdog in a `StallWatchdog` type. The call site kept two parallel `Option`s derived from the same condition and threaded out an `Option<(CancellationToken, JoinHandle<()>)>`. `monitor_for_stall` also took two same-typed `CancellationToken` params pointing opposite directions, where swapping them compiles and yields a run that silently never stalls. - Rename `WorkflowAgentQuestionRuntime::stage_id` and `PendingAgentQuestionBatch::stage_id` to `node_id`. They hold `node.id`, and the previous commit put them two lines from `stage_scope.stage_id()`, which returns a real `StageId`. - Widen the two real-time interview tests. `node_timeout_excludes_ human_input_wait` allowed 20ms of active work against a 50ms budget, which is tight enough to flake under parallel nextest load. The blocked wait still outruns the timeout, so both still fail if the pause regresses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| apps | ||
| components | ||
| foundation | ||
| packages/fabro-api-client | ||