mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-05 02:41:45 +00:00
Phase 2/3 of the std::fs lint initiative (Phase 1 refactors landed in
commit 9d1c0d98c).
clippy.toml additions (appended to disallowed-methods):
std::fs::read, read_to_string, write, read_dir, copy, canonicalize
std::fs::File::open, File::create, File::create_new
std::fs::OpenOptions::open
File::options was deliberately excluded — it returns an OpenOptions
builder with no syscall. OpenOptions::open is where the block happens.
Non-blocking std::fs items (metadata, exists, create_dir_all, remove_*,
rename, and all std::fs types) remain legal.
Annotation policy (per updated plan):
- Mixed async/sync production source: function- or statement-scoped
#[expect(...)] so future accidental Tokio-path regressions in the
same file still fire.
- Fully-sync production source, test modules, integration tests,
build.rs: file-level #![expect(...)].
- Every #[expect] has a specific reason identifying the sync context.
Annotations added in ~90 files across the workspace. Notable narrow
placements: fabro-server server.rs current_server_target,
build_disk_usage_response, create_test_app_state_with_session_key;
fabro-server install.rs read_to_string rollback snapshot;
fabro-sandbox local.rs list_recursive; fabro-agent cli.rs FOLLOW-UP on
the JSON-stdout writer; fabro-llm providers/common.rs FOLLOW-UP for
load_file_as_base64 (7 translator call sites; revisit if file:// URL
usage grows).
build.rs blanket allows: fabro-api/build.rs, fabro-util/build.rs.
Pre-existing unrelated nightly-clippy warnings fixed under scope:
fabro-sandbox sandbox_spec.rs (unused_imports, unused_async),
reconnect.rs (unused_variables, unused_async).
Verified: cargo +nightly-2026-04-14 clippy --workspace --all-targets
-- -D warnings passes; fmt clean; 4129/4131 tests pass (two known
flakes under parallel nextest load, both pass individually and are
unrelated to this change).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
147 lines
4.3 KiB
Rust
147 lines
4.3 KiB
Rust
#![expect(
|
|
clippy::disallowed_methods,
|
|
reason = "integration tests stage fixtures with sync std::fs; test infrastructure, not Tokio-hot path"
|
|
)]
|
|
|
|
use fabro_test::{fabro_snapshot, test_context};
|
|
|
|
use super::support::{read_text, setup_created_dry_run, setup_local_sandbox_run, text_tree};
|
|
|
|
#[test]
|
|
fn help() {
|
|
let context = test_context!();
|
|
let mut cmd = context.command();
|
|
cmd.args(["sandbox", "cp", "--help"]);
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: true
|
|
exit_code: 0
|
|
----- stdout -----
|
|
Copy files to/from a run's sandbox
|
|
|
|
Usage: fabro sandbox cp [OPTIONS] <SRC> <DST>
|
|
|
|
Arguments:
|
|
<SRC> Source: <run-id>:<path> or local path
|
|
<DST> Destination: <run-id>:<path> or local path
|
|
|
|
Options:
|
|
--json Output as JSON [env: FABRO_JSON=]
|
|
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
|
|
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
|
|
-r, --recursive Recurse into directories
|
|
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
|
|
--quiet Suppress non-essential output [env: FABRO_QUIET=]
|
|
--verbose Enable verbose output [env: FABRO_VERBOSE=]
|
|
-h, --help Print help
|
|
----- stderr -----
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn sandbox_cp_run_without_sandbox_json_errors_cleanly() {
|
|
let context = test_context!();
|
|
let run = setup_created_dry_run(&context);
|
|
let dest = context.temp_dir.join("missing.txt");
|
|
let mut cmd = context.cp();
|
|
cmd.args([&format!("{}:foo.txt", run.run_id), dest.to_str().unwrap()]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: false
|
|
exit_code: 1
|
|
----- stdout -----
|
|
----- stderr -----
|
|
error: Run has no active sandbox.
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn sandbox_cp_downloads_file_from_run() {
|
|
let context = test_context!();
|
|
let setup = setup_local_sandbox_run(&context);
|
|
let dest = context.temp_dir.join("downloaded-root.txt");
|
|
let mut cmd = context.cp();
|
|
cmd.args([
|
|
&format!("{}:sandbox_dir/download_me/root.txt", setup.run.run_id),
|
|
dest.to_str().unwrap(),
|
|
]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: true
|
|
exit_code: 0
|
|
----- stdout -----
|
|
----- stderr -----
|
|
");
|
|
assert_eq!(read_text(&dest), "keep");
|
|
}
|
|
|
|
#[test]
|
|
fn sandbox_cp_downloads_file_from_store_without_sandbox_json() {
|
|
let context = test_context!();
|
|
let setup = setup_local_sandbox_run(&context);
|
|
let dest = context.temp_dir.join("downloaded-from-store.txt");
|
|
let mut cmd = context.cp();
|
|
cmd.args([
|
|
&format!("{}:sandbox_dir/download_me/root.txt", setup.run.run_id),
|
|
dest.to_str().unwrap(),
|
|
]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: true
|
|
exit_code: 0
|
|
----- stdout -----
|
|
----- stderr -----
|
|
");
|
|
assert_eq!(read_text(&dest), "keep");
|
|
}
|
|
|
|
#[test]
|
|
fn sandbox_cp_uploads_file_to_run() {
|
|
let context = test_context!();
|
|
let setup = setup_local_sandbox_run(&context);
|
|
let local = context.temp_dir.join("upload.txt");
|
|
std::fs::write(&local, "uploaded-root")
|
|
.unwrap_or_else(|err| panic!("failed to write {}: {err}", local.display()));
|
|
let mut cmd = context.cp();
|
|
cmd.args([
|
|
local.to_str().unwrap(),
|
|
&format!("{}:sandbox_dir/uploaded.txt", setup.run.run_id),
|
|
]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: true
|
|
exit_code: 0
|
|
----- stdout -----
|
|
----- stderr -----
|
|
");
|
|
assert_eq!(
|
|
read_text(&setup.workspace_dir.join("sandbox_dir/uploaded.txt")),
|
|
"uploaded-root"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sandbox_cp_recursive_downloads_directory() {
|
|
let context = test_context!();
|
|
let setup = setup_local_sandbox_run(&context);
|
|
let dest = context.temp_dir.join("download-dir");
|
|
let mut cmd = context.cp();
|
|
cmd.args([
|
|
"-r",
|
|
&format!("{}:sandbox_dir/download_me", setup.run.run_id),
|
|
dest.to_str().unwrap(),
|
|
]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: true
|
|
exit_code: 0
|
|
----- stdout -----
|
|
----- stderr -----
|
|
");
|
|
insta::assert_snapshot!(
|
|
text_tree(&dest).join("\n"),
|
|
@r"
|
|
nested/child.txt = nested
|
|
root.txt = keep
|
|
"
|
|
);
|
|
}
|