mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-23 00:41:13 +00:00
Reuse the existing merge strategy type across CLI/API/GitHub paths, consolidate repeated PR command setup, and serialize server-side PR creation per run to avoid duplicate external work.
149 lines
4.3 KiB
Rust
149 lines
4.3 KiB
Rust
use std::any::{TypeId, type_name};
|
|
|
|
use fabro_api::types::MergeRunPullRequestRequest;
|
|
use fabro_types::settings::run::MergeStrategy;
|
|
use fabro_types::{PullRequestDetail, PullRequestRecord};
|
|
use serde_json::json;
|
|
|
|
#[test]
|
|
fn pull_request_detail_reuses_domain_record_type() {
|
|
let detail: PullRequestDetail = serde_json::from_value(json!({
|
|
"record": {
|
|
"html_url": "https://github.com/fabro-sh/fabro/pull/123",
|
|
"number": 123,
|
|
"owner": "fabro-sh",
|
|
"repo": "fabro",
|
|
"base_branch": "main",
|
|
"head_branch": "fabro/run/demo",
|
|
"title": "Move PR commands server-side"
|
|
},
|
|
"number": 123,
|
|
"title": "Move PR commands server-side",
|
|
"body": "Generated body",
|
|
"state": "closed",
|
|
"draft": false,
|
|
"merged": true,
|
|
"merged_at": "2026-04-23T15:45:00Z",
|
|
"mergeable": false,
|
|
"additions": 234,
|
|
"deletions": 67,
|
|
"changed_files": 5,
|
|
"html_url": "https://github.com/fabro-sh/fabro/pull/123",
|
|
"user": {
|
|
"login": "octocat"
|
|
},
|
|
"head": {
|
|
"ref": "fabro/run/demo"
|
|
},
|
|
"base": {
|
|
"ref": "main"
|
|
},
|
|
"created_at": "2026-04-23T15:40:00Z",
|
|
"updated_at": "2026-04-23T15:45:00Z"
|
|
}))
|
|
.expect("detail should deserialize");
|
|
|
|
assert_same_type_as_pull_request_record(&detail.record);
|
|
}
|
|
|
|
#[test]
|
|
fn merge_request_reuses_run_merge_strategy_type() {
|
|
let request: MergeRunPullRequestRequest = serde_json::from_value(json!({ "method": "squash" }))
|
|
.expect("merge request should deserialize");
|
|
|
|
assert_same_type_as_merge_strategy(&request.method);
|
|
}
|
|
|
|
#[test]
|
|
fn merge_strategy_json_matches_openapi_shape() {
|
|
assert_eq!(serde_json::to_value(MergeStrategy::Merge).unwrap(), "merge");
|
|
assert_eq!(
|
|
serde_json::to_value(MergeStrategy::Squash).unwrap(),
|
|
"squash"
|
|
);
|
|
assert_eq!(
|
|
serde_json::to_value(MergeStrategy::Rebase).unwrap(),
|
|
"rebase"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn pull_request_record_json_matches_openapi_shape() {
|
|
let fixture = json!({
|
|
"html_url": "https://github.com/fabro-sh/fabro/pull/123",
|
|
"number": 123,
|
|
"owner": "fabro-sh",
|
|
"repo": "fabro",
|
|
"base_branch": "main",
|
|
"head_branch": "fabro/run/demo",
|
|
"title": "Move PR commands server-side"
|
|
});
|
|
|
|
let domain_record: PullRequestRecord =
|
|
serde_json::from_value(fixture.clone()).expect("domain record should deserialize");
|
|
|
|
assert_eq!(serde_json::to_value(domain_record).unwrap(), fixture);
|
|
}
|
|
|
|
#[test]
|
|
fn pull_request_detail_json_matches_openapi_shape() {
|
|
let fixture = json!({
|
|
"record": {
|
|
"html_url": "https://github.com/fabro-sh/fabro/pull/123",
|
|
"number": 123,
|
|
"owner": "fabro-sh",
|
|
"repo": "fabro",
|
|
"base_branch": "main",
|
|
"head_branch": "fabro/run/demo",
|
|
"title": "Move PR commands server-side"
|
|
},
|
|
"number": 123,
|
|
"title": "Move PR commands server-side",
|
|
"body": "Generated body",
|
|
"state": "closed",
|
|
"draft": false,
|
|
"merged": true,
|
|
"merged_at": "2026-04-23T15:45:00Z",
|
|
"mergeable": false,
|
|
"additions": 234,
|
|
"deletions": 67,
|
|
"changed_files": 5,
|
|
"html_url": "https://github.com/fabro-sh/fabro/pull/123",
|
|
"user": {
|
|
"login": "octocat"
|
|
},
|
|
"head": {
|
|
"ref": "fabro/run/demo"
|
|
},
|
|
"base": {
|
|
"ref": "main"
|
|
},
|
|
"created_at": "2026-04-23T15:40:00Z",
|
|
"updated_at": "2026-04-23T15:45:00Z"
|
|
});
|
|
|
|
let detail: PullRequestDetail =
|
|
serde_json::from_value(fixture.clone()).expect("detail should deserialize");
|
|
|
|
assert_eq!(serde_json::to_value(detail).unwrap(), fixture);
|
|
}
|
|
|
|
fn assert_same_type_as_pull_request_record<T: 'static>(_: &T) {
|
|
assert_eq!(
|
|
TypeId::of::<T>(),
|
|
TypeId::of::<PullRequestRecord>(),
|
|
"{} should be the same type as {}",
|
|
type_name::<T>(),
|
|
type_name::<PullRequestRecord>()
|
|
);
|
|
}
|
|
|
|
fn assert_same_type_as_merge_strategy<T: 'static>(_: &T) {
|
|
assert_eq!(
|
|
TypeId::of::<T>(),
|
|
TypeId::of::<MergeStrategy>(),
|
|
"{} should be the same type as {}",
|
|
type_name::<T>(),
|
|
type_name::<MergeStrategy>()
|
|
);
|
|
}
|