mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-05 08:10:39 +00:00
e2f884df23
Fix three bugs from PR review in the new `fabro resume` command: 1. RunArgs.workflow lost its required constraint when --run-branch was removed — add #[arg(required = true)] so clap enforces it. 2. run_resumed ignored --preserve-sandbox (hardcoded false), --verbose (no ProgressUI), and --ssh (no listener). Wire preserve_sandbox through resolve_preserve_sandbox, create a ProgressUI registered on the emitter, and handle SSH access. 3. prepare_from_checkpoint unconditionally created a LocalSandbox, ignoring --sandbox. Add the same sandbox resolution logic used by prepare_from_branch (Local, Docker, Ssh, Exe, Daytona). Remove --ssh from `fabro run` and `fabro resume` since `fabro ssh` is the dedicated command now. Remove the flag from RunArgs, ResumeArgs, RunSpec, and all docs/changelogs. Simplify EventEmitter: change on_event to take &self (via Mutex<Vec<Arc<...>>>) instead of &mut self, removing the need for the late_listeners workaround. emit() snapshots the listener list before dispatching to prevent deadlocks from reentrant emit calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| checkpoints.mdx | ||
| context.mdx | ||
| devcontainers.mdx | ||
| environments.mdx | ||
| failures.mdx | ||
| observability.mdx | ||
| outcomes.mdx | ||
| retros.mdx | ||
| run-configuration.mdx | ||