mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-05 08:10:39 +00:00
d70bc7a166
Five more fixes: P0 — Reorder wizard: Server config now precedes GitHub. The GitHub manifest bakes <canonical_url> into redirect_url and callback_urls; creating the App with a misdetected URL is a real-world side effect we cannot unmake on github.com. P0 — `persist_install_outputs` cannot be reused as-is from install mode. Its vault path goes through `connect_api_client(storage_dir)`, which calls back into the install-mode server itself (which doesn't mount /api/v1/*) and would 404. Add an explicit decision: install mode writes vault secrets directly to disk via Vault::load(...).set(...), the same pattern persist_github_install_changes already uses. TOML and env-file helpers remain reusable. P1 — Bootstrap fork narrowed. Install mode triggers only when no explicit --config or FABRO_CONFIG was provided AND the default ~/.fabro/settings.toml is absent. A typo in --config must error, not silently install on top of the wrong target. Matches the asymmetry the existing config loader already enforces (user.rs:81-112). P1 — Stop overpromising rollback. The existing helper restores settings.toml on vault failure but leaves server.env in place (verified by install.rs:2910). Spec out the actual partial-state semantics for v1, justify why it's acceptable (env keys are deterministic and idempotent on retry), and call atomic rollback a deliberate follow-up. P2 — On-disk layout corrected. Vault path is <storage_dir>/vaults/default/secrets.json (storage.rs:38), not <storage_dir>/secrets/.... Added the home-level dev-token file the CLI also writes (install.rs:1994-1999) so parity is real. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| administration | ||
| agents | ||
| api-reference | ||
| brainstorms | ||
| changelog | ||
| core-concepts | ||
| examples | ||
| execution | ||
| getting-started | ||
| human-tools | ||
| ideation | ||
| images | ||
| integrations | ||
| languages | ||
| logo | ||
| plans | ||
| reference | ||
| superpowers/specs | ||
| tutorials | ||
| workflows | ||
| .mintignore | ||
| docs.json | ||
| dot-highlight.js | ||
| favicon.svg | ||
