Bryan Helmkamp d21d9fa62f docs(install): address fourth review pass on web-install spec ... Three more fixes (all P2): P2 — Goal wording said "using the same persistence helpers" but the body explicitly carves out a separate install-mode vault path. Reword to "same on-disk state, sharing the TOML/env primitives" so the implementer isn't misled about how much of the CLI path is reused. P2 — Summary said only `fabro server start` enters install mode but the process model says start and restart. Reconcile: name both commands explicitly in the summary. P2 — Test plan covered the GitHub App `state` rejection path but not the happy-path roundtrip (POST /install/github/app/manifest → GET /install/github/app/redirect with stubbed conversion). Add an integration test that covers the riskiest new path: code-exchange wiring, session population, redirect-with-token handling, and that the canonical-URL ordering decision actually flows through to the manifest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>		2026-04-18 19:50:44 -04:00
..
specs	docs(install): address fourth review pass on web-install spec	2026-04-18 19:50:44 -04:00