mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-24 00:51:19 +00:00
642e312cca
Eliminate four parallel-type duplications between fabro-api generated DTOs and fabro-types canonical types. The wire shape is owned by OpenAPI; canonical types are reused via fabro-api/build.rs with_replacement so the adapter functions and silent unwrap_or_default defaults disappear. - SecretType moves to fabro-types (was fabro-vault); deletes secret_type_from_api adapter. - DiffLineStats renamed to DiffStats, moved to fabro-types, switched u64 -> i64 to match the OpenAPI integer; deletes line_stats_to_api. - ManifestPreRunPushOutcome rewritten as a oneOf+discriminator PreRunPushOutcome over five variant schemas, deleting both pre_run_push_outcome_from_manifest and build_manifest_push_outcome. - ManifestGit and PreRunGitContext unify as GitContext: dirty: DirtyStatus replaces clean: bool (preserving the Unknown state previously truncated on the wire), sha becomes Option<String>, and origin_url/branch fold into the unified context. RunSpec and RunCreatedProps flatten three fields (repo_origin_url, base_branch, pre_run_git) into a single git: Option<GitContext>. Each replacement gets a fabro-api parity test (TypeId equality plus JSON roundtrip) modeled on run_summary_round_trip.rs. TS client regenerated. Greenfield app, no production deployments — wire contract changed directly without backwards-compat shims. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
101 lines
3 KiB
Rust
101 lines
3 KiB
Rust
use std::any::{TypeId, type_name};
|
|
|
|
use fabro_api::types::{
|
|
DirtyStatus as ApiDirtyStatus, GitContext as ApiGitContext,
|
|
PreRunPushOutcome as ApiPreRunPushOutcome,
|
|
};
|
|
use fabro_types::{DirtyStatus, GitContext, PreRunPushOutcome};
|
|
use serde_json::json;
|
|
|
|
#[test]
|
|
fn git_context_reuses_canonical_types() {
|
|
assert_same_type::<ApiGitContext, GitContext>();
|
|
assert_same_type::<ApiDirtyStatus, DirtyStatus>();
|
|
assert_same_type::<ApiPreRunPushOutcome, PreRunPushOutcome>();
|
|
}
|
|
|
|
#[test]
|
|
fn dirty_status_serializes_with_snake_case_strings() {
|
|
assert_eq!(
|
|
serde_json::to_value(DirtyStatus::Clean).unwrap(),
|
|
json!("clean")
|
|
);
|
|
assert_eq!(
|
|
serde_json::to_value(DirtyStatus::Dirty).unwrap(),
|
|
json!("dirty")
|
|
);
|
|
assert_eq!(
|
|
serde_json::to_value(DirtyStatus::Unknown).unwrap(),
|
|
json!("unknown")
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn git_context_with_known_sha_round_trips() {
|
|
let ctx = GitContext {
|
|
origin_url: "https://github.com/acme/widgets".to_string(),
|
|
branch: "main".to_string(),
|
|
sha: Some("abc123".to_string()),
|
|
dirty: DirtyStatus::Clean,
|
|
push_outcome: PreRunPushOutcome::Succeeded {
|
|
remote: "origin".to_string(),
|
|
branch: "main".to_string(),
|
|
},
|
|
};
|
|
let json = serde_json::to_value(&ctx).unwrap();
|
|
assert_eq!(
|
|
json,
|
|
json!({
|
|
"origin_url": "https://github.com/acme/widgets",
|
|
"branch": "main",
|
|
"sha": "abc123",
|
|
"dirty": "clean",
|
|
"push_outcome": {
|
|
"type": "succeeded",
|
|
"remote": "origin",
|
|
"branch": "main",
|
|
},
|
|
})
|
|
);
|
|
let round_trip: GitContext = serde_json::from_value(json).unwrap();
|
|
assert_eq!(round_trip, ctx);
|
|
}
|
|
|
|
#[test]
|
|
fn git_context_omits_absent_sha_on_serialize() {
|
|
let ctx = GitContext {
|
|
origin_url: "https://github.com/acme/widgets".to_string(),
|
|
branch: "feature/foo".to_string(),
|
|
sha: None,
|
|
dirty: DirtyStatus::Unknown,
|
|
push_outcome: PreRunPushOutcome::SkippedNoRemote,
|
|
};
|
|
let json = serde_json::to_value(&ctx).unwrap();
|
|
assert!(json.get("sha").is_none());
|
|
assert_eq!(json["dirty"], "unknown");
|
|
assert_eq!(json["push_outcome"]["type"], "skipped_no_remote");
|
|
}
|
|
|
|
#[test]
|
|
fn git_context_deserializes_when_sha_is_absent() {
|
|
let ctx: GitContext = serde_json::from_value(json!({
|
|
"origin_url": "https://github.com/acme/widgets",
|
|
"branch": "main",
|
|
"dirty": "dirty",
|
|
"push_outcome": { "type": "not_attempted" },
|
|
}))
|
|
.unwrap();
|
|
assert_eq!(ctx.sha, None);
|
|
assert_eq!(ctx.dirty, DirtyStatus::Dirty);
|
|
assert_eq!(ctx.push_outcome, PreRunPushOutcome::NotAttempted);
|
|
}
|
|
|
|
fn assert_same_type<T: 'static, U: 'static>() {
|
|
assert_eq!(
|
|
TypeId::of::<T>(),
|
|
TypeId::of::<U>(),
|
|
"{} should be the same type as {}",
|
|
type_name::<T>(),
|
|
type_name::<U>()
|
|
);
|
|
}
|