mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-06 08:18:58 +00:00
33 lines
2.5 KiB
Text
33 lines
2.5 KiB
Text
digraph SWEBench {
|
||
graph [goal="Use Admin Inline verbose_name as default for Inline verbose_name_plural
|
||
Description
|
||
|
||
Django allows specification of a verbose_name and a verbose_name_plural for Inline classes in admin views. However, verbose_name_plural for an Inline is not currently based on a specified verbose_name. Instead, it continues to be based on the model name, or an a verbose_name specified in the model's Meta class. This was confusing to me initially (I didn't understand why I had to specify both name forms for an Inline if I wanted to overrule the default name), and seems inconsistent with the approach for a model's Meta class (which does automatically base the plural form on a specified verbose_name). I propose that verbose_name_plural for an Inline class should by default be based on the verbose_name for an Inline if that is specified.
|
||
I have written a patch to implement this, including tests. Would be happy to submit that.
|
||
|
||
|
||
|
||
## Additional Context
|
||
|
||
Please push your patch as a Django pull request."]
|
||
rankdir=LR
|
||
|
||
start [shape=Mdiamond]
|
||
exit [shape=Msquare]
|
||
|
||
setup [label="Setup", shape=parallelogram, script="git clone https://github.com/django/django.git . && git checkout 1bd6a7a0acc11e249fca11c017505ad39f15ebf6 && python -m pip install -e ."]
|
||
solve [label="Solve", prompt="Fix this GitHub issue in the repository. Make the minimal code change needed.\n\nUse Admin Inline verbose_name as default for Inline verbose_name_plural
|
||
Description
|
||
|
||
Django allows specification of a verbose_name and a verbose_name_plural for Inline classes in admin views. However, verbose_name_plural for an Inline is not currently based on a specified verbose_name. Instead, it continues to be based on the model name, or an a verbose_name specified in the model's Meta class. This was confusing to me initially (I didn't understand why I had to specify both name forms for an Inline if I wanted to overrule the default name), and seems inconsistent with the approach for a model's Meta class (which does automatically base the plural form on a specified verbose_name). I propose that verbose_name_plural for an Inline class should by default be based on the verbose_name for an Inline if that is specified.
|
||
I have written a patch to implement this, including tests. Would be happy to submit that.
|
||
|
||
|
||
|
||
## Additional Context
|
||
|
||
Please push your patch as a Django pull request."]
|
||
extract_patch [label="Extract Patch", shape=parallelogram, script="git diff"]
|
||
|
||
start -> setup -> solve -> extract_patch -> exit
|
||
}
|