Bryan Helmkamp c6a78a4286 refactor(events): thread stage scope through emitter ... Populate stage_id / parallel_group_id / parallel_branch_id on every event tied to a concrete stage execution, per the spec at docs-internal/fabro-event-schema-v2-concrete-shape.md:223-279. Before this commit, stored_event_fields() only set stage_id for the four Event::Stage* variants and Event::Agent -- the only variants that carried visit/parallel_group_id/parallel_branch_id in their payload. Every other stage-scoped event (Checkpoint*, PromptCompleted, Command*, AgentCli*, Prompt, Interview*, Failover, StallWatchdog, GitCommit, ArtifactCaptured) fell through to node_stored_fields() and left stage_id as None. New approach: scope is carried alongside the event, not on the variant. - fabro-workflow/src/event.rs: new StageScope type { node_id, visit, parallel_group_id, parallel_branch_id }. New Emitter::emit_scoped(&event, &scope) for stage-level emission. to_run_event_at and stored_event_fields take an Option<&StageScope> that merges into the returned envelope fields. StageScope::for_handler(context, node_id) is the canonical handler-side constructor -- prefers context.current_stage_scope() set by the fidelity lifecycle, falls back to a scope synthesized from the node_id + context visit count for tests that don't go through the full lifecycle. - fabro-workflow/src/context.rs: new WorkflowContext::current_stage_scope() method reads CURRENT_NODE, internal.node_visit_count, internal.parallel_group_id, internal.parallel_branch_id from the context. - Remove the now-redundant visit/parallel_group_id/parallel_branch_id fields from Event::Stage{Started,Completed,Failed,Retrying} and the parallel_* fields from Event::Agent. These existed only to feed stored_event_fields() and are obsolete once scope is threaded through the emitter. Emission site migration (all stage-scoped handlers now use emit_scoped): - lifecycle/event.rs: StageStarted, StageCompleted, StageFailed, StageRetrying, CheckpointCompleted, GitCommit (from on_checkpoint) - lifecycle/git.rs: CheckpointFailed - lifecycle/artifact.rs: ArtifactCaptured - handler/command.rs: CommandStarted, CommandCompleted - handler/prompt.rs: Prompt, PromptCompleted - handler/agent.rs: Prompt, PromptCompleted - handler/fan_in.rs: Prompt, PromptCompleted - handler/human.rs: InterviewStarted, InterviewTimeout, InterviewInterrupted, InterviewCompleted - handler/llm/api.rs: Failover, Agent (via spawn_event_forwarder which now carries a StageScope across the tokio::spawn boundary) - handler/llm/cli.rs: AgentCliStarted, AgentCliCompleted - handler/parallel.rs: ParallelBranchStarted, ParallelBranchCompleted StallWatchdogTimeout stays on plain emit() because the watchdog fires from an error path without a live stage context. Deleted the local StageEventScope struct + current_stage_event_scope helper from handler/llm/api.rs; it's generalized into StageScope. Tests: two new unit tests in event.rs -- stage_scope_populates_stage_id_on_non_stage_events verifies CommandStarted / Prompt / GitCommit all pick up stage_id from scope, run_level_events_without_scope_leave_stage_id_absent confirms run.* events still get no stage scope. Updated all test fixtures across fabro-workflow, fabro-cli to drop the removed Event variant fields. Accepted two insta snapshot updates in fabro-cli/tests/it/cmd/{attach,run}.rs that now include the formerly-missing stage_id fields on checkpoint and interview events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>		2026-04-09 16:34:59 -04:00
..
crates	refactor(events): thread stage scope through emitter	2026-04-09 16:34:59 -04:00
packages/fabro-api-client	fix(api): generate typescript EventEnvelope with typed seq	2026-04-09 16:00:05 -04:00