mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-21 00:21:27 +00:00
642e312cca
Eliminate four parallel-type duplications between fabro-api generated DTOs and fabro-types canonical types. The wire shape is owned by OpenAPI; canonical types are reused via fabro-api/build.rs with_replacement so the adapter functions and silent unwrap_or_default defaults disappear. - SecretType moves to fabro-types (was fabro-vault); deletes secret_type_from_api adapter. - DiffLineStats renamed to DiffStats, moved to fabro-types, switched u64 -> i64 to match the OpenAPI integer; deletes line_stats_to_api. - ManifestPreRunPushOutcome rewritten as a oneOf+discriminator PreRunPushOutcome over five variant schemas, deleting both pre_run_push_outcome_from_manifest and build_manifest_push_outcome. - ManifestGit and PreRunGitContext unify as GitContext: dirty: DirtyStatus replaces clean: bool (preserving the Unknown state previously truncated on the wire), sha becomes Option<String>, and origin_url/branch fold into the unified context. RunSpec and RunCreatedProps flatten three fields (repo_origin_url, base_branch, pre_run_git) into a single git: Option<GitContext>. Each replacement gets a fabro-api parity test (TypeId equality plus JSON roundtrip) modeled on run_summary_round_trip.rs. TS client regenerated. Greenfield app, no production deployments — wire contract changed directly without backwards-compat shims. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
46 lines
1 KiB
Rust
46 lines
1 KiB
Rust
use std::any::{TypeId, type_name};
|
|
|
|
use fabro_api::types::DiffStats as ApiDiffStats;
|
|
use fabro_types::DiffStats;
|
|
use serde_json::json;
|
|
|
|
#[test]
|
|
fn diff_stats_reuses_canonical_type() {
|
|
assert_same_type::<ApiDiffStats, DiffStats>();
|
|
}
|
|
|
|
#[test]
|
|
fn diff_stats_serializes_with_required_integer_fields() {
|
|
let stats = DiffStats {
|
|
additions: 567,
|
|
deletions: 234,
|
|
};
|
|
assert_eq!(
|
|
serde_json::to_value(stats).unwrap(),
|
|
json!({
|
|
"additions": 567,
|
|
"deletions": 234,
|
|
})
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn diff_stats_deserializes_from_required_payload() {
|
|
let stats: DiffStats = serde_json::from_value(json!({
|
|
"additions": 1,
|
|
"deletions": 0,
|
|
}))
|
|
.unwrap();
|
|
assert_eq!(stats.additions, 1);
|
|
assert_eq!(stats.deletions, 0);
|
|
}
|
|
|
|
fn assert_same_type<T: 'static, U: 'static>() {
|
|
assert_eq!(
|
|
TypeId::of::<T>(),
|
|
TypeId::of::<U>(),
|
|
"{} should be the same type as {}",
|
|
type_name::<T>(),
|
|
type_name::<U>()
|
|
);
|
|
}
|