Bryan Helmkamp c44c93ff32 fix(web): complete lifecycle-status coverage + loader integration tests ... Two follow-ups from internal review: 1. deriveEmptyKind was incomplete. The full RunStatus enum (per fabro-types/src/status.rs and apps/fabro-web/app/data/runs.ts) has ten values — submitted, queued, starting, running, blocked, paused, removing, succeeded, failed, dead. My decision table covered only six and incorrectly included "partialsuccess" which is a stage status, not a run status. Unhandled statuses (blocked, paused, removing, dead) silently fell through to the "diff_lost" branch, which showed users the alarmist "the diff for this run is no longer available" copy for runs that are merely paused or being torn down. New table: - submitted / queued / starting → R4(a) "starting" - running / blocked / paused → R4(b) "no_changes" (yet — user can refresh) - failed / dead → R4(c1) "failed before checkpoint" (R4b-equivalent when a degraded patch did survive) - succeeded / removing → R4(c2) "diff_lost" if total_changed > 0, else R4(b) - unknown future status → R4 "unknown" fallback Test suite now drives each documented status through a regression guard that asserts no known status collapses to "unknown" when a more-specific kind should apply. 2. Loader integration tests. The `extractRequestId` unit test covers only the extractor; nothing exercised the full fetch → body-read → requestId → error chain. Added 8 loader tests covering: - 200 OK returns the parsed envelope - 404 / 501 collapse to the empty-envelope signal (null + null) - 500 with `request_id` in errors[0] populates error.requestId - 500 without a request_id leaves it null - 500 with non-JSON body still surfaces the status - 503 populates error without requestId - 401 surfaces as an error (no in-loader redirect — that concern lives in apiFetch, which the Files loader deliberately bypasses to preserve error bodies) The tests stub globalThis.fetch; the loader already accepts the cancellation-signal-only `request` object. Refs docs/plans/2026-04-19-002-feat-run-files-changed-tab-plan.md § Unit 11 R4/R5 taxonomies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>		2026-04-19 18:37:41 -04:00
..
crates	fix(web): complete lifecycle-status coverage + loader integration tests	2026-04-19 18:37:41 -04:00
packages/fabro-api-client	feat(api): add GET /runs/{id}/files spec + RunFilesMeta schema	2026-04-19 15:33:24 -04:00