mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-04 02:33:56 +00:00
7dd058cc40
Implements the plan at
docs/plans/2026-04-20-003-refactor-unify-run-vocabulary-metadata-plan.md.
- Rename RunRecord to RunSpec and RunProjection.run to .spec everywhere
in Rust source, tests, helpers, test names, and error messages.
- Introduce SerializableProjection wrapper that trims bulky node text
fields (prompt, response, diff, stdout, stderr) for run.json snapshots.
- Collapse metadata-branch and CLI export to one RunDump::from_projection
builder emitting run.json + graph.fabro + stages/{stage_id}/... and
drop legacy top-level start/status/checkpoint/sandbox/retro/conclusion
split files.
- Replace MetadataStore::write_checkpoint with write_snapshot returning
the commit SHA; add read_run_projection/read_run_spec; demote
read_checkpoint/read_start_record to projection-field extractors.
- Switch fork, rewind, rebuild_meta, CLI rewind recovery, and retro
upload to read the unified projection layout.
- Add additive query methods on RunSpec and RunProjection.
Serde-level `alias = "spec"` shim dropped; `rename = "run"` retained to
keep the server API wire format stable per the plan's scope boundary.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
114 lines
3.4 KiB
Rust
114 lines
3.4 KiB
Rust
use fabro_test::{fabro_snapshot, test_context};
|
|
|
|
use super::support::{setup_completed_fast_dry_run, setup_created_fast_dry_run, setup_failed_run};
|
|
|
|
#[test]
|
|
fn help() {
|
|
let context = test_context!();
|
|
let mut cmd = context.command();
|
|
cmd.args(["pr", "create", "--help"]);
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: true
|
|
exit_code: 0
|
|
----- stdout -----
|
|
Create a pull request from a completed run
|
|
|
|
Usage: fabro pr create [OPTIONS] <RUN_ID>
|
|
|
|
Arguments:
|
|
<RUN_ID> Run ID or prefix
|
|
|
|
Options:
|
|
--json Output as JSON [env: FABRO_JSON=]
|
|
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
|
|
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
|
|
--model <MODEL> LLM model for generating PR description
|
|
-f, --force Create PR even if the run status is not success/partial_success
|
|
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
|
|
--quiet Suppress non-essential output [env: FABRO_QUIET=]
|
|
--verbose Enable verbose output [env: FABRO_VERBOSE=]
|
|
-h, --help Print help
|
|
----- stderr -----
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn pr_create_unfinished_run_errors_before_network() {
|
|
let context = test_context!();
|
|
let run = setup_created_fast_dry_run(&context);
|
|
let mut cmd = context.command();
|
|
cmd.args(["pr", "create", &run.run_id]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: false
|
|
exit_code: 1
|
|
----- stdout -----
|
|
----- stderr -----
|
|
error: Failed to load start record from store
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn pr_create_completed_dry_run_without_run_branch_errors() {
|
|
let context = test_context!();
|
|
let run = setup_completed_fast_dry_run(&context);
|
|
let mut cmd = context.command();
|
|
cmd.args(["pr", "create", &run.run_id]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: false
|
|
exit_code: 1
|
|
----- stdout -----
|
|
----- stderr -----
|
|
error: Run has no run_branch — was it run with git push enabled?
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn pr_create_uses_store_run_spec_without_run_json() {
|
|
let context = test_context!();
|
|
let run = setup_completed_fast_dry_run(&context);
|
|
|
|
let mut cmd = context.command();
|
|
cmd.args(["pr", "create", &run.run_id]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: false
|
|
exit_code: 1
|
|
----- stdout -----
|
|
----- stderr -----
|
|
error: Run has no run_branch — was it run with git push enabled?
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn pr_create_failed_run_rejects_without_force() {
|
|
let context = test_context!();
|
|
let run = setup_failed_run(&context);
|
|
let mut cmd = context.command();
|
|
cmd.args(["pr", "create", &run.run_id]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: false
|
|
exit_code: 1
|
|
----- stdout -----
|
|
----- stderr -----
|
|
error: Run status is 'fail', expected success or partial_success
|
|
");
|
|
}
|
|
|
|
#[test]
|
|
fn pr_create_failed_run_proceeds_with_force() {
|
|
let context = test_context!();
|
|
let run = setup_failed_run(&context);
|
|
let mut cmd = context.command();
|
|
cmd.args(["pr", "create", "--force", &run.run_id]);
|
|
|
|
fabro_snapshot!(context.filters(), cmd, @"
|
|
success: false
|
|
exit_code: 1
|
|
----- stdout -----
|
|
----- stderr -----
|
|
error: Run has no run_branch — was it run with git push enabled?
|
|
");
|
|
}
|