Bryan Helmkamp ae55bded81 fix(sandbox): clone Daytona repos under /home/daytona/repos (#285) ... ## Summary Daytona's default snapshot runs as the `daytona` user (uid 1001), which lacks write permission on `/`. With `run.clone.enabled = true`, sandbox init failed at `fs.create_folder("/repos", ...)` with HTTP 400, before the first workflow stage could run: ``` sandbox.git.failed error="Failed to create Daytona repos root" causes=["HTTP 400"] run.failed ``` Root cause: the Daytona provider was using Docker's root-level `/repos` layout. Docker works because its containers run as root; Daytona's default sandbox user does not. **Fix:** move `REPOS_ROOT` for Daytona to `/home/daytona/repos`, alongside the existing `/home/daytona/workspace`. The path is writable by the default sandbox user, the symlink layout is unchanged (`/home/daytona/workspace/<repo>` → `/home/daytona/repos/<owner>/<repo>`), and Docker keeps its existing `/repos` path. **Bonus — better error diagnostics.** A new `wrap_fs_error(operation, path, error)` helper in the Daytona provider: - includes the attempted path in the message (was just "Failed to create Daytona repos root" with no indication of which path); - classifies HTTP 400 as a likely permission issue and points at snapshot configuration; - classifies HTTP 401/403 as an API key permissions issue; - preserves the underlying `DaytonaError` in the source chain (per `docs/internal/error-handling-strategy.md` — verified by walking `Error::source()` in the regression test). So if this class of failure recurs (custom snapshot, future path changes, ...) the user gets: > Failed to create Daytona repos root '/home/daytona/repos' failed > (HTTP 400). This usually means the sandbox user lacks write permission > on the parent directory. If you're using a custom Daytona snapshot, > ensure the sandbox user can write to '/home/daytona/repos', or use a > path under the user's home directory (e.g. /home/daytona/...). instead of: > Failed to create Daytona repos root > HTTP 400 ## Test plan - [x] `cargo build --workspace` - [x] `cargo nextest run -p fabro-sandbox --features daytona` — 142/142 pass - [x] `cargo nextest run -p fabro-types -p fabro-workflow` — 1365/1365 pass - [x] New unit test `wrap_fs_error_classifies_http_400_and_403` — asserts top-level message contains path + hint AND walks the source chain to prove `DaytonaError::Api { status_code: 400, .. }` is preserved - [x] `cargo +nightly-2026-04-14 fmt --check --all` - [x] `cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings` - [x] **Live regression**: `daytona_clone_layout_live_smoke` against the default `daytona-medium` snapshot — failed with `Failed to create Daytona repos root / HTTP 400` before the change; passes end-to-end after (provisions sandbox → clones repo → verifies symlink + HEAD match in 2.5s) ## Related - Closes #284 (thanks @jessmartin for the report, diagnosis, and proposed fix) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Jess Martin <27258+jessmartin@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>		2026-05-16 13:47:54 -04:00
..
crates	fix(sandbox): clone Daytona repos under /home/daytona/repos (#285)	2026-05-16 13:47:54 -04:00
packages/fabro-api-client	feat(errors): add structured failure diagnostics (#277)	2026-05-16 13:25:07 -04:00