mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-18 04:47:08 +00:00
d17599898e
## Summary The run Overview tab's "Created by" cell rendered every user as a colored circle with the first letter of their login. Reviewers and run owners expected the same GitHub avatar shown on `/profile` and in the top-right nav. The cell only had `login` to work with — the `PrincipalUser` schema carried no avatar URL. This threads an optional `avatar_url` through `UserPrincipal` end-to-end: schema, server auth, and frontend. The avatar is captured at action time from the request's auth context and persisted with the run's `created_by` principal — a point-in-time snapshot, the same pattern as audit logs and chat apps. ## What changed - **`fabro-types`** — `UserPrincipal` gains `avatar_url: Option<String>` with `#[serde(default, skip_serializing_if)]`, plus a `Principal::user_with_avatar` constructor. The existing `Principal::user` constructor is unchanged (sets `None`), so test fixtures and CLI/replay call sites need no edits. - **OpenAPI** — `PrincipalUser` gains an optional nullable `avatar_url`; Rust (progenitor) and TypeScript clients regenerated. - **`fabro-server`** — `auth_context_from_session` (cookie auth) and `classify_user_token` (JWT auth) populate the principal's avatar from the session/JWT, treating an empty string as `None`. - **`fabro-web`** — the `run-summary-panel` "Created by" cell renders an `<img>` when `avatar_url` is present, falling back to the initial circle otherwise. ## Compatibility The field is optional with serde defaults, so old persisted runs and `RunEvent.actor` payloads deserialize unchanged — they show the initial-circle fallback. No migration or backfill. ## Known gap CLI-initiated runs (`fabro run ...`) still show the initial circle: the CLI auth flow hardcodes an empty `avatar_url` in the JWT subject (`cli_flow.rs:508`). Wiring the avatar through CLI login (`~/.fabro/auth.json`, JWT claims, refresh-token chain) is a deliberate follow-up. Web-initiated runs get the avatar today. ## Test plan - `cargo nextest run --workspace` — 5,832 tests pass, including new `principal.rs` and `principal_round_trip.rs` cases covering avatar serialization and legacy-JSON (no-field) deserialization. - `cd apps/fabro-web && bun test run-summary-panel` — 13 tests pass, including a new case asserting the `<img>` renders with the avatar src. - `bun run typecheck`, `cargo +nightly-2026-04-14 fmt --check --all`, and `clippy --workspace --all-targets -- -D warnings` all clean. - Manual: restart `fabro server`, create a run from the web UI, confirm the real avatar renders on the Overview tab; confirm an older run falls back to the initial circle. --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with Claude Opus 4.7 (1M context, extended thinking) via [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| 2026-04-29-metadata-snapshot-events.md | ||
| 2026-04-30-duplicate-type-unification.md | ||
| 2026-04-30-preserve-exec-failure-diagnostics.md | ||
| 2026-05-02-event-module-split.md | ||
| 2026-05-02-server-readiness-timeouts.md | ||
| 2026-05-02-settings-driven-llm-providers-models.md | ||
| 2026-05-04-cross-tab-sse-coordination.md | ||
| 2026-05-04-model-test-bounded-concurrency.md | ||
| 2026-05-04-unique-git-checkpoint-commit-message-path.md | ||
| 2026-05-05-clean-pierre-virtualizer-integration.md | ||
| 2026-05-05-decouple-interrupts-from-steering.md | ||
| 2026-05-06-cli-input-overrides.md | ||
| 2026-05-06-improve-cli-api-error-display.md | ||
| 2026-05-06-polished-foreground-tty-logging.md | ||
| 2026-05-08-generated-typescript-api-client-migration.md | ||
| 2026-05-08-run-owned-sandbox-lifecycle.md | ||
| 2026-05-09-daytona-run-terminal.md | ||
| 2026-05-09-fixed-project-workflow-directory.md | ||
| 2026-05-09-inline-markdown-run-titles.md | ||
| 2026-05-09-live-stage-token-projection.md | ||
| 2026-05-09-remove-local-worktree-mode.md | ||
| 2026-05-09-run-files-diff-scope-picker.md | ||
| 2026-05-10-auth-sessions-backend.md | ||
| 2026-05-10-auth-sessions-frontend.md | ||
| 2026-05-10-live-events-page.md | ||
| 2026-05-10-sandbox-services-backend.md | ||
| 2026-05-10-sandbox-services-frontend.md | ||
| 2026-05-11-automations-end-to-end.md | ||
| 2026-05-13-path-based-daytona-dockerfiles.md | ||
| 2026-05-13-sandbox-repo-layout-plan.md | ||
| 2026-05-14-optional-llm-install.md | ||
| 2026-05-15-sandbox-network-details.md | ||
| 2026-05-16-chats-new-fabro-web-port.md | ||
| 2026-05-16-source-aware-template-diagnostics.md | ||
| 2026-05-16-static-workflow-structure-rendering.md | ||
| 2026-05-17-live-provider-workflow-testing.md | ||
| 2026-05-17-provider-adapter-boundary-cleanup.md | ||
| 2026-05-18-server-side-run-pairing-api-events.md | ||
| 2026-05-18-vault-and-credential-source-cleanup.md | ||