brynary-fabro[bot] 9e676796ea Fix: Workflow TOML config lost in detach mode (#138) ... This PR fixes a bug where workflow TOML configuration (including `[pull_request]` settings) was silently dropped when running in detached mode (`fabro run -d`). The root cause was a three-part failure: `create.rs` checked the raw CLI argument string for a `.toml` extension instead of the resolved path, so `run.toml` was never written to the run directory; `RunEngine` always fell back to `graph.fabro` (a DOT file), causing `prepare_workflow` to return `run_cfg = None` and lose all TOML-level configuration; and `pull_request`/`asset_globs` fields in `RunConfig` had no fallback to `run_defaults` when `run_cfg` was absent. The fix replaces the naive file-copy approach with a proper serialization pipeline. Rather than copying the raw TOML (which would contain a `graph` field pointing to a nonexistent file in the run directory), `create.rs` now calls `write_run_config_snapshot`, which serializes the already-merged `WorkflowRunConfig` and rewrites the `graph` field to `"graph.fabro"` — the canonical cached name. This makes the run directory fully self-contained with all defaults merged, environment variables resolved, and the graph path correct. `RunEngine` in `main.rs` now unconditionally points at `run.toml`; a new `resolve_workflow_source` helper handles the `.toml` path by loading the config and resolving the graph path, with a backward-compatible fallback to `graph.fabro` for older detached runs created before this change. As defense-in-depth, fallbacks to `run_defaults` are added throughout `run.rs` for `pull_request`, `asset_globs`, `devcontainer`, and `sandbox.env` — ensuring bare `.fabro` files passed directly still pick up project-level defaults. Two new unit tests verify the serialization round-trip (confirming `graph` is rewritten and `pull_request` config is preserved) and the missing-`run.toml` fallback behavior. ### Fabro Details <details> <summary>Ran 9 stages in 26m 29s for $9.17</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 0s | – | 0 | | preflight_compile | 1m 14s | – | 0 | | preflight_lint | 13s | – | 0 | | implement | 4m 54s | $0.71 | 0 | | simplify_opus | 8m 41s | $1.77 | 0 | | simplify_gpt | 10m 41s | $6.69 | 0 | | verify | 18s | – | 0 | | fmt | 1s | – | 0 | | **Total** | **26m 29s** | **$9.17** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (12 nodes and 15 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-6; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo clippy -q --workspace -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD."] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-54)", prompt="@prompts/simplify.md", model="gpt-54"] verify [label="Verify", shape=parallelogram, script="cargo clippy -q --workspace -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all clippy lint warnings and test failures.", max_visits=3] fmt [label="Format", shape=parallelogram, script="cargo fmt --all 2>&1", max_retries=0] start -> toolchain toolchain -> preflight_compile [condition="outcome=success"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=success"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=success"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> fmt [condition="outcome=success"] verify -> fixup fixup -> verify fmt -> exit } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh> Co-authored-by: Bryan Helmkamp <bryan@brynary.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>		2026-03-21 14:15:13 -04:00
..
crates	Fix: Workflow TOML config lost in detach mode (#138)	2026-03-21 14:15:13 -04:00
packages/fabro-api-client	Designate retros as experimental, disable by default via [features] flag	2026-03-15 20:36:32 -04:00