Bryan Helmkamp 9837a08929 refactor(install): share persistence pipeline (#332) ... ## Summary Unifies installer persistence so CLI and web install paths share the same file/env/vault primitives, while preserving the CLI's server-API secret persistence and auth bootstrap behavior. ## What Changed - Added shared `fabro-install` config writers for installer-owned tagged enum tables, replacing `server.listen` and `cli.target` atomically so stale variant fields cannot survive. - Added `InstallPersistencePlan` for disk-backed settings, server env, and vault writes/removals with the existing rollback semantics for settings and vault failures. - Refactored `fabro install`, `fabro install github`, and `/install/finish` to use the shared persistence plan where their disk behavior overlaps. - Preserved full-install ordering: settings/env first, workflow-visible secrets through the server API second, and CLI `auth.json` only after API secret persistence succeeds. - Preserved web installer failure response fields for leftover and removed env keys, plus the post-success finish hook/shutdown behavior. ## Test Plan - `cargo nextest run -p fabro-install` - `cargo nextest run -p fabro-cli commands::install::tests` - `cargo nextest run -p fabro-cli --test it cmd::install` - `cargo nextest run -p fabro-server --features test-support --test it api::install` - `cargo +nightly-2026-04-14 fmt --check --all` - `git diff --check` --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with GPT-5 via [Codex](https://openai.com/codex)		2026-05-21 08:04:04 -04:00
..
cmd	refactor(install): share persistence pipeline (#332)	2026-05-21 08:04:04 -04:00
scenario	Add ACP backend support (#237)	2026-05-11 23:39:43 -04:00
support	refactor(runs): simplify run projection shape	2026-05-09 23:31:43 -04:00
workflow	feat(workflow): enforce strict api/acp backends (#307)	2026-05-18 13:20:56 -04:00
main.rs	chore(clippy): require reasons on allow attributes	2026-04-19 20:24:24 -04:00