brynary-fabro[bot] e3967183c6 Fix: Sub-agent file writes not tracked in API backend (#17) ... This PR fixes a bug where files written by sub-agents were missing from `outcome.files_touched`, causing downstream pipeline nodes like `simplify_opus` to receive incomplete file lists. The root cause was that `spawn_event_forwarder` only matched top-level `ToolCallStarted`/`ToolCallCompleted` events, while sub-agent tool calls arrived wrapped in `AgentEvent::SubAgentEvent` and fell through to the `_ => {}` catch-all. The fix extracts the file-tracking logic into a standalone `track_file_event` function that recursively unwraps `SubAgentEvent` layers before matching on the inner tool call events. This handles arbitrarily nested sub-agent hierarchies (sub-sub-agents, etc.). The three separate `Arc<Mutex<...>>` fields for pending calls, touched files, and last file are consolidated into a single `FileTracking` struct behind one lock, simplifying the forwarder signature and reducing lock contention. Four new unit tests verify the behavior: top-level write tracking, single-level sub-agent unwrapping, double-nested sub-sub-agent unwrapping, and proper cleanup of pending entries on tool call errors. ### Fabro Details <details> <summary>Ran 10 stages in 22m 1s for $4.18</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 0s | – | 0 | | preflight_compile | 0s | – | 0 | | preflight_lint | 0s | – | 0 | | implement | 0s | $0.91 | 0 | | simplify_opus | 0s | $0.89 | 0 | | simplify_gemini | 0s | $1.44 | 0 | | simplify_gpt | 0s | $0.94 | 0 | | verify | 0s | – | 0 | | fmt | 0s | – | 0 | | **Total** | **22m 1s** | **$4.18** | **0** | </details> <details> <summary>Ran <code>ImplementAndSimplify.fabro</code> (13 nodes and 16 edges)</summary> ```dot digraph ImplementAndSimplify { graph [ goal="Implement and simplify", model_stylesheet=" * { backend: api; model: claude-opus-4-6;} " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo clippy -q --workspace -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD."] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gemini [label="Simplify (Gemini)", prompt="@prompts/simplify.md", model="gemini-3.1-pro-preview-customtools"] simplify_gpt [label="Simplify (GPT-54)", prompt="@prompts/simplify.md", model="gpt-54"] verify [label="Verify", shape=parallelogram, script="cargo clippy -q --workspace -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all clippy lint warnings and test failures.", max_visits=3] fmt [label="Format", shape=parallelogram, script="cargo fmt --all 2>&1", goal_gate=true, max_retries=0] start -> toolchain toolchain -> preflight_compile [condition="outcome=success"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=success"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=success"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gemini -> simplify_gpt -> verify verify -> fmt [condition="outcome=success"] verify -> fixup fixup -> verify fmt -> exit } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>		2026-03-15 23:18:40 -04:00
..
crates	Fix: Sub-agent file writes not tracked in API backend (#17)	2026-03-15 23:18:40 -04:00
packages/fabro-api-client	Designate retros as experimental, disable by default via [features] flag	2026-03-15 20:36:32 -04:00