mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-23 00:41:13 +00:00
## Summary
Adds event-sourced pull request association management for runs while
preserving Fabro-created PR creation. A run can now store a current
GitHub PR association, replace it by linking another GitHub PR URL, and
remove it through an unlink event.
## What Changed
- Added `pull_request.linked` and `pull_request.unlinked` events,
projection replay support, and optional PR metadata fields in shared
pull request records.
- Added API, server, and client support for `PUT
/runs/{id}/pull_request` and `DELETE /runs/{id}/pull_request`; linking
accepts GitHub PR URLs, infers owner/repo/number, and captures live
GitHub title and branch metadata when available.
- Added `fabro pr link` and `fabro pr unlink`, updated `fabro pr view`,
and kept create/merge/close behavior guarded to GitHub PRs with usable
coordinates.
- Updated web UI rendering and internal event docs so stored PR links
display cleanly when live GitHub details are unavailable.
## Testing
- `cargo +nightly-2026-04-14 fmt --check --all`
- `git diff --check`
- `cargo build -p fabro-api`
- `cargo nextest run -p fabro-types -p fabro-store -p fabro-server -p
fabro-cli`
- `bun run typecheck` in `lib/packages/fabro-api-client`
- `bun run typecheck` in `apps/fabro-web`
- `bun test` in `apps/fabro-web`
Refs https://github.com/fabro-sh/fabro/issues/235
---
[](https://github.com/EveryInc/compound-engineering-plugin)
🤖 Generated with GPT-5 via [Codex](https://openai.com/codex)
---------
Co-authored-by: Haroldo Olivieri <6575718+haroldolivieri@users.noreply.github.com>
157 lines
4.6 KiB
Rust
157 lines
4.6 KiB
Rust
#![allow(
|
||
clippy::absolute_paths,
|
||
reason = "This test module prefers explicit type paths over extra imports."
|
||
)]
|
||
|
||
use fabro_test::{fabro_snapshot, test_context};
|
||
use httpmock::MockServer;
|
||
|
||
use super::support::{mock_resolved_run, setup_seeded_completed_dry_run};
|
||
use crate::support::unique_run_id;
|
||
|
||
#[test]
|
||
fn help() {
|
||
let context = test_context!();
|
||
let mut cmd = context.command();
|
||
cmd.args(["pr", "create", "--help"]);
|
||
fabro_snapshot!(context.filters(), cmd, @"
|
||
success: true
|
||
exit_code: 0
|
||
----- stdout -----
|
||
Create a pull request from a completed run
|
||
|
||
Usage: fabro pr create [OPTIONS] <RUN_ID>
|
||
|
||
Arguments:
|
||
<RUN_ID> Run ID or prefix
|
||
|
||
Options:
|
||
--json Output as JSON [env: FABRO_JSON=]
|
||
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
|
||
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
|
||
--model <MODEL> LLM model for generating PR description
|
||
-f, --force Create PR even if the run status is not succeeded/partially_succeeded
|
||
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
|
||
--quiet Suppress non-essential output [env: FABRO_QUIET=]
|
||
--verbose Enable verbose output [env: FABRO_VERBOSE=]
|
||
-h, --help Print help
|
||
----- stderr -----
|
||
");
|
||
}
|
||
|
||
#[test]
|
||
fn pr_create_nongit_run_reports_missing_repo_origin() {
|
||
let context = test_context!();
|
||
let run = setup_seeded_completed_dry_run(&context);
|
||
|
||
let mut cmd = context.command();
|
||
cmd.args(["pr", "create", &run.run_id]);
|
||
|
||
fabro_snapshot!(context.filters(), cmd, @"
|
||
success: false
|
||
exit_code: 1
|
||
----- stdout -----
|
||
----- stderr -----
|
||
× Run has no repo origin URL — pull request creation requires git metadata.
|
||
");
|
||
}
|
||
|
||
#[test]
|
||
fn pr_create_uses_server_endpoint_and_prints_url() {
|
||
let context = test_context!();
|
||
let server = MockServer::start();
|
||
let run_id = unique_run_id();
|
||
|
||
let resolve_mock = mock_resolved_run(&server, "nightly-build", &run_id);
|
||
let create_mock = server.mock(|when, then| {
|
||
when.method("POST")
|
||
.path(format!("/api/v1/runs/{run_id}/pull_request"))
|
||
.header("content-type", "application/json")
|
||
.json_body(serde_json::json!({
|
||
"force": false
|
||
}));
|
||
then.status(200)
|
||
.header("Content-Type", "application/json")
|
||
.json_body(serde_json::json!({
|
||
"owner": "fabro-sh",
|
||
"repo": "fabro",
|
||
"number": 123,
|
||
"html_url": "https://github.com/fabro-sh/fabro/pull/123"
|
||
}));
|
||
});
|
||
|
||
let mut cmd = context.command();
|
||
cmd.args([
|
||
"pr",
|
||
"create",
|
||
"--server",
|
||
&server.base_url(),
|
||
"nightly-build",
|
||
]);
|
||
|
||
fabro_snapshot!(context.filters(), cmd, @"
|
||
success: true
|
||
exit_code: 0
|
||
----- stdout -----
|
||
https://github.com/fabro-sh/fabro/pull/123
|
||
----- stderr -----
|
||
");
|
||
|
||
resolve_mock.assert();
|
||
create_mock.assert();
|
||
}
|
||
|
||
#[test]
|
||
fn pr_create_passes_force_and_model_to_server() {
|
||
let context = test_context!();
|
||
let server = MockServer::start();
|
||
let run_id = unique_run_id();
|
||
|
||
let resolve_mock = mock_resolved_run(&server, "nightly-build", &run_id);
|
||
let create_mock = server.mock(|when, then| {
|
||
when.method("POST")
|
||
.path(format!("/api/v1/runs/{run_id}/pull_request"))
|
||
.header("content-type", "application/json")
|
||
.json_body(serde_json::json!({
|
||
"force": true,
|
||
"model": "gpt-5.2"
|
||
}));
|
||
then.status(200)
|
||
.header("Content-Type", "application/json")
|
||
.json_body(serde_json::json!({
|
||
"owner": "fabro-sh",
|
||
"repo": "fabro",
|
||
"number": 123,
|
||
"html_url": "https://github.com/fabro-sh/fabro/pull/123"
|
||
}));
|
||
});
|
||
|
||
let mut cmd = context.command();
|
||
cmd.args([
|
||
"pr",
|
||
"create",
|
||
"--json",
|
||
"--force",
|
||
"--model",
|
||
"gpt-5.2",
|
||
"--server",
|
||
&server.base_url(),
|
||
"nightly-build",
|
||
]);
|
||
|
||
fabro_snapshot!(context.filters(), cmd, @r#"
|
||
success: true
|
||
exit_code: 0
|
||
----- stdout -----
|
||
{
|
||
"owner": "fabro-sh",
|
||
"repo": "fabro",
|
||
"number": 123,
|
||
"html_url": "https://github.com/fabro-sh/fabro/pull/123"
|
||
}
|
||
----- stderr -----
|
||
"#);
|
||
|
||
resolve_mock.assert();
|
||
create_mock.assert();
|
||
}
|