fabro/lib/crates/fabro-cli/src
Bryan Helmkamp 87dc7de140
fix(install): clear carried clippy warnings across install code paths
The web-install feature was carrying nine pedantic-tier clippy errors
from its initial commit. Fix them in place:

- \`install.rs\` \`InstallAppState\` switches \`install_token\`,
  \`storage_dir\`, and \`config_path\` from \`Arc<String>/Arc<PathBuf>\` to
  \`Arc<str>/Arc<Path>\` so we stop heap-duplicating buffers.
- Bring \`Infallible\`, \`axum::middleware\`, \`axum::extract::Request\`,
  and \`fabro_types::settings::SettingsLayer\` into scope instead of
  using absolute paths inline.
- Replace \`Duration::from_secs(10 * 60)\` with \`Duration::from_mins(10)\`.
- \`generate_ephemeral_secret\` never returns \`Err\`; drop the \`Result\`.
- \`server/start.rs ensure_storage_server_autostart_allowed\` takes
  \`Option<&OsStr>\` instead of consuming an \`OsString\` it only reads.
- \`server/mod.rs\` storage_dir fallback uses \`map_or_else\` to satisfy
  \`map_unwrap_or\`.

CI now passes \`cargo +nightly-2026-04-14 clippy --workspace
--all-targets -- -D warnings\` cleanly and the 892-test suite still
passes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 14:13:10 -04:00
..
commands fix(install): clear carried clippy warnings across install code paths 2026-04-19 14:13:10 -04:00
shared fix(cli): improve device code login readability with blank line spacing 2026-04-16 07:20:57 -04:00
sleep_inhibitor refactor(async): lint std::process::Command across all targets 2026-04-12 13:35:57 -04:00
args.rs feat(cli): surface debug build profile in version output 2026-04-18 09:44:54 -04:00
command_context.rs refactor(cli): route global args through settings layer 2026-04-14 12:27:59 -04:00
gh.rs feat(install): let user choose GitHub App owner (personal or org) 2026-04-10 09:32:05 -04:00
landing.rs feat(cli): add fabro docs to landing Set up section 2026-04-17 09:03:40 -04:00
logging.rs fmt 2026-04-11 11:27:46 -04:00
main.rs feat(cli): show curated landing output for bare fabro 2026-04-17 08:59:03 -04:00
manifest_builder.rs refactor(config): move project state under .fabro 2026-04-11 12:55:46 -04:00
server_client.rs Merge remote-tracking branch 'origin/main' 2026-04-19 13:36:54 -04:00
server_runs.rs fmt: apply nightly rustfmt after merge 2026-04-11 13:43:30 -04:00
sse.rs refactor(cli): stream run attach over SSE 2026-04-07 12:58:37 -04:00
user_config.rs fix: wrap propagated io errors with anyhow context across prod code 2026-04-17 11:44:38 -04:00