mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-15 23:32:46 +00:00
e8f0aceee8
## Summary
Separates Fabro server secrets into two explicit scopes: **bootstrap**
secrets that come from process env or `server.env`, and **optional
integration** secrets that come exclusively from the vault. This makes
secret resolution simple and predictable, and removes all `process env →
server.env` fallback paths for optional integrations such as GitHub App,
Slack, Daytona, Brave Search, and LLM provider keys.
## What changed
**New `ToolSecrets` struct in `fabro-agent`** — Brave Search API key is
now passed explicitly through `SessionOptions.tool_secrets` rather than
read from process env inside the tool. The standalone CLI reads the key
at the CLI boundary (with an explicit
`#[expect(clippy::disallowed_methods)]` annotation); the server will
read it from the vault. The error message changes from
`"BRAVE_SEARCH_API_KEY environment variable is not set"` to
`"BRAVE_SEARCH_API_KEY is not configured"`.
**`VaultCredentialSource::vault_only` constructor in `fabro-auth`** —
Adds a constructor that passes `|_| None` as the env lookup, ensuring
the server LLM credential source never resolves provider keys from
process env.
**GitHub App secrets move to vault in install flows** — Both the CLI
`fabro install github` path and the browser install finish handler now
write `GITHUB_APP_PRIVATE_KEY`, `GITHUB_APP_CLIENT_SECRET`, and
`GITHUB_APP_WEBHOOK_SECRET` to the vault instead of `server.env`.
Switching strategies removes stale secrets from the other strategy's
storage location. The `vault_set` field type changes from `Vec<(String,
String)>` to `Vec<VaultSecretWrite>` to carry per-secret type metadata
(file vs. token).
**`fabro-vault` gains a `fabro-static` dependency** — Needed so the
vault crate can reference canonical env-var names from the shared
registry without a cycle.
**`GH_TOKEN` fallback removed** — `GITHUB_TOKEN` is now read from the
vault only; the changelog and `server-configuration.mdx` note drops
mention of `GH_TOKEN` as an accepted fallback.
**Version bump** — Workspace crates promoted from `0.244.0-nightly.0` to
`0.244.0`.
**Docs** — Internal strategy doc, public admin docs (Docker, Railway,
server-configuration, security, troubleshooting), and integration docs
(GitHub, Slack, Daytona, Brave Search, LiteLLM, tools reference, models)
all updated to reflect vault-only optional secrets and direct users to
`fabro secret set` rather than process env or `server.env`.
### Plan Summary
- **Task 1** (secret registry) — not yet present in this diff;
classification lives in the places that consume it.
- **Task 3–6** (vault-only lookups for GitHub, Slack, Daytona, LLM) —
implemented via `vault_only` constructor, `tool_secrets` threading, and
install-path changes.
- **Task 7** (Brave Search explicit injection) — `ToolSecrets`,
`register_core_tools` wiring, CLI boundary read.
- **Task 8** (install persistence) — GitHub App secrets written to
vault; token strategy writes `GITHUB_TOKEN` to vault and clears app
vault keys; app strategy clears `GITHUB_TOKEN` vault key.
- **Task 9** (docs) — all public and internal docs updated.
### Fabro Details
<details>
<summary>Ran 0 stages in 155m 26s for $60.85</summary>
| Stage | Duration | Cost | Retries |
|---|---|---|---|
| **Total** | **155m 26s** | **$60.85** | **0** |
</details>
<details>
<summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14
edges)</summary>
```dot
digraph ImplementPlan {
graph [
goal="Implement and simplify",
model_stylesheet="
* { model: claude-opus-4-7; }
"
]
rankdir=LR
start [shape=Mdiamond, label="Start"]
exit [shape=Msquare, label="Exit"]
toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0]
preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0]
preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0]
fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3]
implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"]
simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"]
simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"]
verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"]
fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3]
start -> toolchain
toolchain -> preflight_compile [condition="outcome=succeeded"]
toolchain -> exit
preflight_compile -> preflight_lint [condition="outcome=succeeded"]
preflight_compile -> exit
preflight_lint -> implement [condition="outcome=succeeded"]
preflight_lint -> fix_lints
fix_lints -> preflight_lint
implement -> simplify_opus -> simplify_gpt -> verify
verify -> exit [condition="outcome=succeeded"]
verify -> fixup
fixup -> verify
}
```
</details>
⚒️ Generated with [Fabro](https://fabro.sh)
---------
Co-authored-by: Fabro <noreply@fabro.sh>
Co-authored-by: Bryan Helmkamp <bryan@brynary.com>
|
||
|---|---|---|
| .. | ||
| 2026-04-02-001-feat-server-daemon-management-plan.md | ||
| 2026-04-02-002-feat-http-store-client-auto-start-plan.md | ||
| 2026-04-04-run-event-simplification-plan.md | ||
| 2026-04-04-shared-nextest-test-daemon-plan.md | ||
| 2026-04-05-cli-deglobalize-server-url-and-storage-dir-plan.md | ||
| 2026-04-05-cli-exec-explicit-local-and-mode-removal-plan.md | ||
| 2026-04-05-cli-model-server-canonical-and-llm-removal-plan.md | ||
| 2026-04-05-cli-run-lifecycle-cleanup-compaction-plan.md | ||
| 2026-04-05-run-adjacent-server-only-cleanup-plan.md | ||
| 2026-04-05-run-create-server-target-plan.md | ||
| 2026-04-05-run-manifest-and-preflight-plan.md | ||
| 2026-04-05-server-canonical-secrets-doctor-repo-plan.md | ||
| 2026-04-06-cli-config-socket-storage-separation-plan.md | ||
| 2026-04-06-object-backed-artifact-uploads.md | ||
| 2026-04-06-settings-command-server-local-merge-plan.md | ||
| 2026-04-06-subprocess-run-workers-signal-control-plan.md | ||
| 2026-04-07-fix-attach-terminal-authoritative-stream-plan.md | ||
| 2026-04-07-global-cas-blob-refs-plan.md | ||
| 2026-04-07-interview-control-channel-and-server-slack-plan.md | ||
| 2026-04-07-run-manifest-blobs-and-bundle-removal-plan.md | ||
| 2026-04-07-run-state-projection-consolidation-plan.md | ||
| 2026-04-07-store-dump-server-owned-export-plan.md | ||
| 2026-04-07-worker-http-only-run-store-migration-plan.md | ||
| 2026-04-08-001-feat-fabro-uninstall-command-plan.md | ||
| 2026-04-08-cli-services-command-context-refactor-plan.md | ||
| 2026-04-08-fabro-spa-asset-crate-plan.md | ||
| 2026-04-08-optional-web-ui-server-plan.md | ||
| 2026-04-08-production-web-ui-test-plan.md | ||
| 2026-04-08-production-web-ui.md | ||
| 2026-04-08-settings-toml-redesign-implementation-plan.md | ||
| 2026-04-09-settings-toml-redesign-handoff-2.md | ||
| 2026-04-09-settings-toml-redesign-handoff-3.md | ||
| 2026-04-09-settings-toml-redesign-handoff-4.md | ||
| 2026-04-09-settings-toml-redesign-handoff.md | ||
| 2026-04-15-002-feat-ip-allowlist-plan.md | ||
| 2026-04-15-canonical-blocked-run-status-plan.md | ||
| 2026-04-18-001-feat-webhook-strategy-plan.md | ||
| 2026-04-19-001-feat-archived-run-status-plan.md | ||
| 2026-04-19-002-feat-run-files-changed-tab-plan.md | ||
| 2026-04-19-002-feat-web-ui-lifecycle-actions-plan.md | ||
| 2026-04-19-003-feat-cli-auth-login-plan.md | ||
| 2026-04-19-home-storage-path-ownership-cleanup-plan.md | ||
| 2026-04-19-remove-inbound-tls-termination-plan.md | ||
| 2026-04-20-001-fix-cli-server-same-host-assumptions-plan.md | ||
| 2026-04-20-002-refactor-extract-fabro-client-crate-plan.md | ||
| 2026-04-20-003-refactor-fabro-store-record-abstractions-plan.md | ||
| 2026-04-20-003-refactor-unify-run-vocabulary-metadata-plan.md | ||
| 2026-04-22-001-refactor-settings-api-entrypoints-plan.md | ||
| 2026-04-22-002-feat-web-install-object-store-step-plan.md | ||
| 2026-04-22-003-refactor-lock-down-server-secrets-plan.md | ||
| 2026-04-22-004-refactor-worker-jwt-auth-plan.md | ||
| 2026-04-23-001-refactor-collapse-settings-resolve-indirection-plan.md | ||
| 2026-04-23-001-refactor-command-context-alignment-plan.md | ||
| 2026-04-23-002-refactor-combine-trait-uv-pattern-plan.md | ||
| 2026-04-23-003-refactor-config-types-boundary-and-dense-migration-plan.md | ||
| 2026-04-23-003-refactor-llm-client-resolution-and-run-services-plan.md | ||
| 2026-04-23-003-refactor-pr-commands-server-side-plan.md | ||
| 2026-04-23-004-refactor-converge-rewind-into-fork-plan.md | ||
| 2026-04-24-001-refactor-adopt-uv-patterns-plan.md | ||
| 2026-04-25-001-refactor-docker-sandbox-clone-based-plan.md | ||
| 2026-04-27-sandbox-native-git-metadata-plan.md | ||
| 2026-04-28-collapse-in-place-types-plan.md | ||
| 2026-04-30-001-feat-command-output-streaming-cas-logs-plan.md | ||
| 2026-05-03-fix-agent-stage-cancellation-plan.md | ||
| 2026-05-08-remove-retro-stage-plan.md | ||
| 2026-05-09-plural-pull-request-data-model-plan.md | ||
| 2026-05-10-sandbox-capabilities-follow-on-plan.md | ||
| 2026-05-10-sandbox-details-tab-plan.md | ||
| 2026-05-10-unified-run-type-shape-plan.md | ||
| 2026-05-11-add-acp-backend-test-plan.md | ||
| 2026-05-11-add-acp-backend.md | ||
| 2026-05-11-add-fabro-mcp-server-test-plan.md | ||
| 2026-05-11-add-fabro-mcp-server.md | ||
| 2026-05-11-daytona-real-agent-smoke-qa-plan.md | ||
| 2026-05-13-rich-run-failure-contract-plan.md | ||
| 2026-05-20-acp-steering-plan.md | ||
| 2026-05-21-wall-and-active-time-metrics-plan.md | ||
| 2026-05-22-001-fix-mcp-create-schema-mismatch-plan.md | ||
| 2026-05-22-002-remove-session-sandboxes-feature-flag-plan.md | ||
| 2026-05-22-ask-fabro-sidebar-wiring.md | ||
| run-projection-simplification.md | ||