Bryan Helmkamp 74834c31a0 refactor(settings): stage 6.3b shrink server runtime types + delete Combine ... Prunes `fabro-types/src/settings/server.rs` down to just the three types that still have live consumers: - `ApiAuthStrategy` — used by `fabro-server::jwt_auth::resolve_auth_mode_with_lookup` - `TlsSettings` — used by `fabro-server::tls::*` and the mTLS integration test - `ApiSettings` — the shim struct built by `fabro-server::serve::build_legacy_api_settings` so the pre-v2 `resolve_auth_mode_with_lookup` signature still compiles Deletes the rest as dead code (all unreferenced in the workspace): `AuthProvider`, `AuthSettings`, `GitProvider`, `GitSettings`, `GitAuthorSettings`, `WebSettings`, `WebhookSettings`, `WebhookStrategy`, `SlackSettings`, `FeaturesSettings`, `LogSettings`, `ArtifactStorageBackend`, `ArtifactStorageSettings`. Trims the `ApiSettings` struct itself to just the two fields the auth resolver reads; drops the never-used `base_url` field and the `build_legacy_api_settings` lines that were computing it. Drops `pub use settings::{ArtifactStorageBackend, ArtifactStorageSettings}` from `fabro-types/src/lib.rs`. Also deletes the dead `Combine` trait machinery alongside its only remaining consumers: - `lib/crates/fabro-types/src/combine.rs` — deleted. - `pub mod combine;` / `pub use fabro_macros::Combine;` removed from `fabro-types/src/lib.rs`. - `#[proc_macro_derive(Combine)] fn derive_combine` — deleted from `fabro-macros/src/lib.rs` along with its `syn::{Data, DeriveInput, Fields}` imports. The `e2e_test` proc-macro is untouched. The seven legacy runtime type modules (`hook`, `mcp`, `project`, `run`, `sandbox`, `user`, plus now the bulk of `server`) are effectively all gone. Only a tiny `server.rs` remains as a transitional home for the three auth-resolver types until Stage 6.6g rewrites `resolve_auth_mode_with_lookup` to walk the v2 `server.auth.api` subtree directly. 3,758 workspace tests pass. `cargo fmt --check --all` and `cargo clippy --workspace -- -D warnings` are clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>		2026-04-09 18:27:46 -04:00
..
crates	refactor(settings): stage 6.3b shrink server runtime types + delete Combine	2026-04-09 18:27:46 -04:00
packages/fabro-api-client	refactor(api): stage 6.6 collapse settings DTOs to freeform v2 shape	2026-04-09 17:04:33 -04:00