brynary-fabro[bot] 69a16431c4 Detect GitHub App visibility mismatch during repo init (#99) ... This PR detects when a GitHub App's visibility will prevent installation on a cross-owner repository during `fabro repo init`. Previously, when the app wasn't installed, users saw only a generic "install at" URL with no indication of why the install link might not work—particularly confusing when the repo belongs to a different owner than the app and the app is private. Two new functions are added to `fabro-github`: `get_authenticated_app()` fetches the app's metadata (slug and owner) via the authenticated `GET /app` endpoint, and `is_app_public()` probes `GET /apps/{slug}` without authentication to determine visibility (public apps return 200, private ones return 404). In `init.rs`, when the app is not installed, we now compare the app owner against the repo owner and, if they differ and the app is private, display a targeted warning explaining that the app must be made public along with a direct link to the settings page. All new checks are best-effort—failures are silently ignored so the existing flow is unaffected. The PR also introduces a `GITHUB_API_BASE_URL` constant to replace hardcoded URL strings and adds five unit tests covering the new functions: successful app info retrieval, auth failure handling, public/private app detection, and verification that the visibility check sends no `Authorization` header. ### Fabro Details <details> <summary>Ran 10 stages in 18m 26s for $4.40</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 0s | – | 0 | | preflight_compile | 1m 13s | – | 0 | | preflight_lint | 13s | – | 0 | | implement | 3m 23s | $0.94 | 0 | | simplify_opus | 5m 17s | $1.44 | 0 | | simplify_gemini | 2m 52s | $0.92 | 0 | | simplify_gpt | 3m 24s | $1.10 | 0 | | verify | 1m 25s | – | 0 | | fmt | 1s | – | 0 | | **Total** | **18m 26s** | **$4.40** | **0** | </details> <details> <summary>Ran <code>ImplementAndSimplify.fabro</code> (13 nodes and 16 edges)</summary> ```dot digraph ImplementAndSimplify { graph [ goal="Implement and simplify", model_stylesheet=" * { backend: api; model: claude-opus-4-6;} " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo clippy -q --workspace -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD."] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gemini [label="Simplify (Gemini)", prompt="@prompts/simplify.md", model="gemini-3.1-pro-preview-customtools"] simplify_gpt [label="Simplify (GPT-54)", prompt="@prompts/simplify.md", model="gpt-54"] verify [label="Verify", shape=parallelogram, script="cargo clippy -q --workspace -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all clippy lint warnings and test failures.", max_visits=3] fmt [label="Format", shape=parallelogram, script="cargo fmt --all 2>&1", max_retries=0] start -> toolchain toolchain -> preflight_compile [condition="outcome=success"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=success"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=success"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gemini -> simplify_gpt -> verify verify -> fmt [condition="outcome=success"] verify -> fixup fixup -> verify fmt -> exit } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>		2026-03-19 12:29:55 -04:00
..
crates	Detect GitHub App visibility mismatch during repo init (#99)	2026-03-19 12:29:55 -04:00
packages/fabro-api-client	Designate retros as experimental, disable by default via [features] flag	2026-03-15 20:36:32 -04:00