mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-17 04:37:03 +00:00
3d77d371c6
The manifest builder's best-effort pre-run push converted every result into a PreRunPushOutcome that was serialized into GitContext, expanded into five OpenAPI union arms, and generated into API clients — but no production path ever read it; every field read was a test. Delete the concept while preserving the behavior: - Drop the PreRunPushOutcome enum and GitContext.push_outcome from fabro-types; GitContext keeps origin_url, branch, optional sha, and dirty, which remain real execution inputs and provenance. - Rename the manifest outcome builder to push_manifest_branch_best_effort, a side-effect-only helper with the same decision rules: skip without an origin, skip on configured-repository mismatch, skip when the branch is already synced, otherwise push noninteractively and discard the result without failing manifest creation or logging raw Git stderr. - Prove the push through repository state instead of the deleted enum: a branch ahead of a local bare origin is pushed during manifest build, a mismatched configured repository is not, and a failing remote helper still cannot fail manifest creation. - Remove push_outcome from GitContext in OpenAPI, delete the five-arm union schemas, and drop the fabro-api type replacement and re-export. - Keep one regression proving historical run.created events with a nested push_outcome still deserialize through ordinary unknown-field tolerance and reserialize to the reduced shape. No migration or event rewrite. Old JSON carrying the removed field stays readable. Newly generated clients omit a field older servers required, so new-client-to-old-server compatibility is intentionally not promised for this pre-1.0 contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| event | ||
| graph | ||
| handler | ||
| lifecycle | ||
| operations | ||
| pipeline | ||
| records | ||
| transforms | ||
| artifact.rs | ||
| artifact_snapshot.rs | ||
| artifact_upload.rs | ||
| billing_rollup.rs | ||
| command_log.rs | ||
| condition.rs | ||
| context.rs | ||
| error.rs | ||
| event.rs | ||
| file_resolver.rs | ||
| git.rs | ||
| github_token_source.rs | ||
| graph.rs | ||
| hook_context.rs | ||
| interview_runtime.rs | ||
| lib.rs | ||
| model_fallback.rs | ||
| node_handler.rs | ||
| outcome.rs | ||
| pull_request.rs | ||
| retry.rs | ||
| run_control.rs | ||
| run_dir.rs | ||
| run_lookup.rs | ||
| run_materialization.rs | ||
| run_metadata.rs | ||
| run_options.rs | ||
| run_status.rs | ||
| runtime_store.rs | ||
| sandbox_git.rs | ||
| sandbox_git_runtime.rs | ||
| services.rs | ||
| stage_execution.rs | ||
| stage_scope.rs | ||
| static_reference.rs | ||
| steering_hub.rs | ||
| test_support.rs | ||
| workflow_bundle.rs | ||