fabro/lib/components/fabro-workflow/src/context.rs
Bryan Helmkamp ec5aeeb5c2
Tighten the prompt-demotion pass after review
Apply the cleanup findings from a four-angle review (reuse,
simplification, efficiency, altitude) of the demotion change:

- Share one size gate: serialized_if_over now backs both offload_value
  and demote_value_for_prompt, restoring the cheap short-string and
  scalar pre-checks so per-node demotion no longer serializes every
  small value just to measure it.
- Stop re-writing blobs every node: materialize_value_bytes writes the
  sandbox file directly from the in-hand bytes and short-circuits on the
  content-addressed file's existence, so an already-demoted value costs
  one existence probe instead of a store round-trip per node visit. The
  local file write is shared with materialize_blob_ref.
- Demote over the resolved snapshot map instead of re-snapshotting a
  Context copy, making the context and outcome loops symmetric and
  saving a full deep clone per node; the fidelity lifecycle builds the
  Context after the pass.
- Skip the pass entirely for Full and Truncate fidelities (nothing
  renders context values), except parallel nodes whose branch stash may
  render at a richer fidelity.
- Build is_preamble_hidden_key on is_engine_internal_key instead of
  restating its prefixes, and call it directly from the preamble
  renderer rather than through a wrapper.
- Document that outcome updates are demoted wholesale and that
  BranchWorkItem.item carries the prompt-ready (possibly demoted) item;
  drop the item rebinding and redundant test assertions; restore the
  local integration test's confinement assertion and make the remote
  one non-vacuous.

Skipped by choice: unifying the crate's several truncation helpers and
rendering the marker through the "See:" pointer family (cross-module
coupling out of proportion to the preview cosmetics), per-branch
demotion inside parallel.results (wholesale demotion is what bounds the
total), and cross-node demotion memoization (the file-existence
short-circuit already reduces repeats to a stat).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FH8Jj9Y4E4Tu5g1jwDtHAb
2026-08-21 21:21:59 -04:00

576 lines
19 KiB
Rust

pub mod keys {
//! Static context key constants and helper functions for dynamic keys.
//!
//! All context keys used across the engine, handlers, and preamble are
//! defined here to prevent typos and improve discoverability.
// --- Top-level keys ---
pub const CURRENT_NODE: &str = "current_node";
pub const OUTCOME: &str = "outcome";
pub const FAILURE_CLASS: &str = "failure_class";
pub const FAILURE_SIGNATURE: &str = "failure_signature";
pub const PREFERRED_LABEL: &str = "preferred_label";
pub const LAST_STAGE: &str = "last_stage";
pub const LAST_RESPONSE: &str = "last_response";
pub const REVIEW_TARGET: &str = "review_target";
// --- graph.* keys ---
pub const GRAPH_GOAL: &str = "graph.goal";
// --- internal.* keys ---
pub const INTERNAL_RUN_ID: &str = "internal.run_id";
pub const INTERNAL_WORK_DIR: &str = "internal.work_dir";
pub const INTERNAL_FIDELITY: &str = "internal.fidelity";
pub const INTERNAL_THREAD_ID: &str = "internal.thread_id";
pub const INTERNAL_NODE_VISIT_COUNT: &str = "internal.node_visit_count";
/// 1-based stage execution ordinal for the currently-executing node — the
/// numeric component of the external `StageId`. Runtime-only: reserved by
/// the lifecycle when a stage execution first becomes observable and
/// stripped from durable context snapshots, unlike
/// [`INTERNAL_NODE_VISIT_COUNT`], which remains the checkpointed graph
/// visit.
pub const INTERNAL_STAGE_EXECUTION_ORDINAL: &str = "internal.stage_execution_ordinal";
pub const INTERNAL_PARENT_PREAMBLE: &str = "internal.parent_preamble";
pub const INTERNAL_PARALLEL_GROUP_ID: &str = "internal.parallel_group_id";
pub const INTERNAL_PARALLEL_BRANCH_ID: &str = "internal.parallel_branch_id";
/// Stash of pre-rendered per-branch preambles for a parallel node; see
/// [`super::ParallelBranchPreamble`] for the entry shape and the
/// producer/consumer contract.
pub const INTERNAL_PARALLEL_BRANCH_PREAMBLES: &str = "internal.parallel_branch_preambles";
// --- current.* keys ---
pub const CURRENT_PREAMBLE: &str = "current.preamble";
// --- command.* keys ---
pub const COMMAND_OUTPUT: &str = "command.output";
// --- human.gate.* keys ---
pub const HUMAN_GATE_SELECTED: &str = "human.gate.selected";
pub const HUMAN_GATE_LABEL: &str = "human.gate.label";
pub const HUMAN_GATE_TEXT: &str = "human.gate.text";
// --- parallel.* keys ---
pub const PARALLEL_RESULTS: &str = "parallel.results";
pub const PARALLEL_BRANCH_COUNT: &str = "parallel.branch_count";
/// Runtime-only keys stripped from durable context projections.
pub(crate) const TRANSIENT_CONTEXT_KEYS: &[&str] = &[
CURRENT_PREAMBLE,
INTERNAL_PARALLEL_BRANCH_PREAMBLES,
INTERNAL_STAGE_EXECUTION_ORDINAL,
];
// --- Prefix constants (for filtering and dynamic keys) ---
pub const GRAPH_PREFIX: &str = "graph.";
pub const INTERNAL_PREFIX: &str = "internal.";
pub const CURRENT_PREFIX: &str = "current";
pub const THREAD_PREFIX: &str = "thread.";
pub const RESPONSE_PREFIX: &str = "response.";
pub const INTERNAL_RETRY_COUNT_PREFIX: &str = "internal.retry_count.";
/// Keys the prompt preamble never renders as context values: engine
/// bookkeeping, per-thread cursors, and values the per-stage sections
/// already present.
#[must_use]
pub(crate) fn is_preamble_hidden_key(key: &str) -> bool {
is_engine_internal_key(key)
|| key.starts_with(RESPONSE_PREFIX)
|| key == OUTCOME
|| key == LAST_STAGE
|| key == LAST_RESPONSE
|| key == PREFERRED_LABEL
}
// --- Helper functions for dynamic keys ---
#[must_use]
pub fn response_key(node_id: &str) -> String {
format!("{RESPONSE_PREFIX}{node_id}")
}
#[must_use]
pub fn thread_current_node_key(thread_id: &str) -> String {
format!("{THREAD_PREFIX}{thread_id}.current_node")
}
#[must_use]
pub fn graph_attr_key(attr: &str) -> String {
format!("{GRAPH_PREFIX}{attr}")
}
#[must_use]
pub fn retry_count_key(node_id: &str) -> String {
format!("{INTERNAL_RETRY_COUNT_PREFIX}{node_id}")
}
/// Returns `true` for engine-internal keys that should not propagate from
/// child to parent workflow contexts.
#[must_use]
pub fn is_engine_internal_key(key: &str) -> bool {
key.starts_with(INTERNAL_PREFIX)
|| key.starts_with(GRAPH_PREFIX)
|| key.starts_with(THREAD_PREFIX)
|| key.starts_with(CURRENT_PREFIX)
}
pub use fabro_graphviz::Fidelity;
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn response_key_formats_correctly() {
assert_eq!(response_key("plan"), "response.plan");
}
#[test]
fn thread_current_node_key_formats_correctly() {
assert_eq!(thread_current_node_key("main"), "thread.main.current_node");
}
#[test]
fn graph_attr_key_formats_correctly() {
assert_eq!(graph_attr_key("goal"), "graph.goal");
}
#[test]
fn retry_count_key_formats_correctly() {
assert_eq!(retry_count_key("plan"), "internal.retry_count.plan");
}
#[test]
fn is_engine_internal_key_classifies_correctly() {
// Keys that ARE engine-internal (should not propagate)
assert!(is_engine_internal_key("internal.run_id"));
assert!(is_engine_internal_key("internal.fidelity"));
assert!(is_engine_internal_key("internal.parent_preamble"));
assert!(is_engine_internal_key("graph.goal"));
assert!(is_engine_internal_key("thread.main.current_node"));
assert!(is_engine_internal_key("current.preamble"));
assert!(is_engine_internal_key("current_node"));
// Keys that are NOT engine-internal (should propagate)
assert!(!is_engine_internal_key("response.plan"));
assert!(!is_engine_internal_key("command.output"));
assert!(!is_engine_internal_key("outcome"));
assert!(!is_engine_internal_key("last_stage"));
assert!(!is_engine_internal_key("review.result"));
assert!(!is_engine_internal_key(REVIEW_TARGET));
assert!(!is_engine_internal_key("user.name"));
}
}
}
use std::collections::HashMap;
pub use fabro_core::Context;
use fabro_graphviz::Fidelity;
use fabro_types::{ParallelBranchId, RunId, StageId};
use serde::{Deserialize, Serialize};
use crate::error::Error;
use crate::event::StageScope;
/// Keys whose values changed or were added in `after` relative to `before`.
/// Takes `after` by value so changed entries move instead of clone.
pub(crate) fn context_diff(
before: &HashMap<String, serde_json::Value>,
after: HashMap<String, serde_json::Value>,
) -> HashMap<String, serde_json::Value> {
after
.into_iter()
.filter(|(key, value)| before.get(key) != Some(value))
.collect()
}
/// [`context_diff`] restricted to user-visible keys: the diff that should
/// propagate outside the executing scope (to a parent workflow or across a
/// parallel fork), with engine-internal keys removed.
pub(crate) fn context_diff_public(
before: &HashMap<String, serde_json::Value>,
after: HashMap<String, serde_json::Value>,
) -> HashMap<String, serde_json::Value> {
context_diff(before, after)
.into_iter()
.filter(|(key, _)| !keys::is_engine_internal_key(key))
.collect()
}
/// Read a context key the way workflow authors write one: the declared key
/// first, then the same key with a leading `context.` stripped.
///
/// The lookup is flat. `context.plan.title` reads the literal keys
/// `context.plan.title` and `plan.title`; it never walks into a nested object.
pub(crate) fn lookup_flat(context: &Context, key: &str) -> Option<serde_json::Value> {
if let Some(bare) = key.strip_prefix("context.") {
return context.get(key).or_else(|| context.get(bare));
}
context.get(key)
}
/// One entry of the [`keys::INTERNAL_PARALLEL_BRANCH_PREAMBLES`] stash.
///
/// The stash is a JSON array indexed by the parallel node's outgoing-edge
/// order. `null` entries mean the branch inherits the fork's preamble.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub(crate) struct ParallelBranchPreamble {
pub(crate) fidelity: Fidelity,
pub(crate) preamble: String,
}
/// Domain-specific typed accessors for workflow context values.
pub trait WorkflowContext {
fn fidelity(&self) -> Fidelity;
fn thread_id(&self) -> Option<String>;
fn preamble(&self) -> String;
fn run_id(&self) -> String;
/// Parse `internal.run_id`, failing when the engine did not seed a
/// valid run ID.
fn parsed_run_id(&self) -> Result<RunId, Error>;
fn parallel_group_id(&self) -> Option<StageId>;
fn parallel_branch_id(&self) -> Option<ParallelBranchId>;
/// Build the stage-level emit scope from the currently-executing node and
/// its execution ordinal. Returns `None` for run-level emissions
/// where no stage is active (i.e., `CURRENT_NODE` is unset).
fn current_stage_scope(&self) -> Option<StageScope>;
}
impl WorkflowContext for Context {
fn fidelity(&self) -> Fidelity {
self.get_string(keys::INTERNAL_FIDELITY, "")
.parse()
.unwrap_or_default()
}
fn thread_id(&self) -> Option<String> {
self.get(keys::INTERNAL_THREAD_ID)
.and_then(|v| v.as_str().map(String::from))
}
fn preamble(&self) -> String {
self.get_string(keys::CURRENT_PREAMBLE, "")
}
fn run_id(&self) -> String {
self.get_string(keys::INTERNAL_RUN_ID, "unknown")
}
fn parsed_run_id(&self) -> Result<RunId, Error> {
self.run_id()
.parse()
.map_err(|err| Error::handler_with_source("invalid internal run_id", err))
}
fn parallel_group_id(&self) -> Option<StageId> {
self.get(keys::INTERNAL_PARALLEL_GROUP_ID)
.and_then(|value| serde_json::from_value(value).ok())
}
fn parallel_branch_id(&self) -> Option<ParallelBranchId> {
self.get(keys::INTERNAL_PARALLEL_BRANCH_ID)
.and_then(|value| serde_json::from_value(value).ok())
}
fn current_stage_scope(&self) -> Option<StageScope> {
let node_id = self
.get(keys::CURRENT_NODE)
.and_then(|value| value.as_str().map(String::from))?;
Some(StageScope::from_context(self, node_id))
}
}
#[cfg(test)]
mod tests {
use std::collections::HashMap;
use super::*;
#[test]
fn new_context_is_empty() {
let ctx = Context::new();
assert!(ctx.snapshot().is_empty());
}
#[test]
fn set_and_get() {
let ctx = Context::new();
ctx.set("key", serde_json::json!("value"));
assert_eq!(ctx.get("key"), Some(serde_json::json!("value")));
}
#[test]
fn lookup_flat_prefers_the_exact_key_then_strips_the_context_prefix() {
let ctx = Context::new();
ctx.set("context.items", serde_json::json!(["exact"]));
ctx.set("items", serde_json::json!(["fallback"]));
assert_eq!(
lookup_flat(&ctx, "context.items"),
Some(serde_json::json!(["exact"]))
);
// An explicit null is a value, not a miss, so it wins over the bare key.
ctx.set("context.items", serde_json::Value::Null);
assert_eq!(
lookup_flat(&ctx, "context.items"),
Some(serde_json::Value::Null)
);
let bare_only = Context::new();
bare_only.set("items", serde_json::json!(["fallback"]));
assert_eq!(
lookup_flat(&bare_only, "context.items"),
Some(serde_json::json!(["fallback"]))
);
assert_eq!(
lookup_flat(&bare_only, "items"),
Some(serde_json::json!(["fallback"]))
);
assert_eq!(lookup_flat(&bare_only, "context.missing"), None);
}
#[test]
fn get_missing_key() {
let ctx = Context::new();
assert_eq!(ctx.get("missing"), None);
}
#[test]
fn context_diff_detects_additions() {
let before = HashMap::new();
let mut after = HashMap::new();
after.insert("key".to_string(), serde_json::json!("value"));
let diff = context_diff(&before, after);
assert_eq!(diff.len(), 1);
assert_eq!(diff.get("key"), Some(&serde_json::json!("value")));
}
#[test]
fn context_diff_detects_changes() {
let mut before = HashMap::new();
before.insert("key".to_string(), serde_json::json!("old"));
let mut after = HashMap::new();
after.insert("key".to_string(), serde_json::json!("new"));
let diff = context_diff(&before, after);
assert_eq!(diff.len(), 1);
assert_eq!(diff.get("key"), Some(&serde_json::json!("new")));
}
#[test]
fn context_diff_ignores_unchanged() {
let mut before = HashMap::new();
before.insert("key".to_string(), serde_json::json!("same"));
let mut after = HashMap::new();
after.insert("key".to_string(), serde_json::json!("same"));
let diff = context_diff(&before, after);
assert!(diff.is_empty());
}
#[test]
fn context_diff_ignores_deletions() {
let mut before = HashMap::new();
before.insert("removed".to_string(), serde_json::json!("gone"));
let after = HashMap::new();
let diff = context_diff(&before, after);
assert!(diff.is_empty());
}
#[test]
fn context_diff_public_excludes_engine_internal_keys() {
let before = HashMap::new();
let mut after = HashMap::new();
after.insert("graph.goal".to_string(), serde_json::json!("child goal"));
after.insert(
"internal.run_id".to_string(),
serde_json::json!("child-run"),
);
after.insert(
"thread.main.current_node".to_string(),
serde_json::json!("exit"),
);
after.insert("current_node".to_string(), serde_json::json!("exit"));
after.insert("response.plan".to_string(), serde_json::json!("the plan"));
after.insert("review.result".to_string(), serde_json::json!("approved"));
let filtered = context_diff_public(&before, after);
assert_eq!(filtered.len(), 2);
assert!(filtered.contains_key("response.plan"));
assert!(filtered.contains_key("review.result"));
}
#[test]
fn get_string_with_value() {
let ctx = Context::new();
ctx.set("name", serde_json::json!("alice"));
assert_eq!(ctx.get_string("name", "default"), "alice");
}
#[test]
fn get_string_missing_key() {
let ctx = Context::new();
assert_eq!(ctx.get_string("missing", "fallback"), "fallback");
}
#[test]
fn get_string_non_string_value() {
let ctx = Context::new();
ctx.set("num", serde_json::json!(42));
assert_eq!(ctx.get_string("num", "default"), "default");
}
#[test]
fn snapshot_is_independent() {
let ctx = Context::new();
ctx.set("a", serde_json::json!(1));
let snap = ctx.snapshot();
ctx.set("b", serde_json::json!(2));
assert!(snap.contains_key("a"));
assert!(!snap.contains_key("b"));
}
#[test]
fn fork_is_independent() {
let ctx = Context::new();
ctx.set("shared", serde_json::json!("original"));
let forked = ctx.fork();
forked.set("shared", serde_json::json!("modified"));
assert_eq!(ctx.get("shared"), Some(serde_json::json!("original")));
assert_eq!(forked.get("shared"), Some(serde_json::json!("modified")));
}
#[test]
fn apply_updates() {
let ctx = Context::new();
ctx.set("existing", serde_json::json!("old"));
let mut updates = HashMap::new();
updates.insert("existing".to_string(), serde_json::json!("new"));
updates.insert("added".to_string(), serde_json::json!(true));
ctx.apply_updates(&updates);
assert_eq!(ctx.get("existing"), Some(serde_json::json!("new")));
assert_eq!(ctx.get("added"), Some(serde_json::json!(true)));
}
#[test]
fn default_creates_empty_context() {
let ctx = Context::default();
assert!(ctx.snapshot().is_empty());
}
#[test]
fn run_id_default() {
let ctx = Context::new();
assert_eq!(ctx.run_id(), "unknown");
}
#[test]
fn run_id_set() {
let ctx = Context::new();
ctx.set(keys::INTERNAL_RUN_ID, serde_json::json!("abc-123"));
assert_eq!(ctx.run_id(), "abc-123");
}
#[test]
fn fidelity_default() {
let ctx = Context::new();
assert_eq!(ctx.fidelity(), keys::Fidelity::Compact);
}
#[test]
fn fidelity_set() {
let ctx = Context::new();
ctx.set(keys::INTERNAL_FIDELITY, serde_json::json!("full"));
assert_eq!(ctx.fidelity(), keys::Fidelity::Full);
}
#[test]
fn preamble_default() {
let ctx = Context::new();
assert_eq!(ctx.preamble(), "");
}
#[test]
fn preamble_set() {
let ctx = Context::new();
ctx.set(keys::CURRENT_PREAMBLE, serde_json::json!("hello"));
assert_eq!(ctx.preamble(), "hello");
}
#[test]
fn thread_id_default() {
let ctx = Context::new();
assert_eq!(ctx.thread_id(), None);
}
#[test]
fn thread_id_null() {
let ctx = Context::new();
ctx.set(keys::INTERNAL_THREAD_ID, serde_json::Value::Null);
assert_eq!(ctx.thread_id(), None);
}
#[test]
fn thread_id_set() {
let ctx = Context::new();
ctx.set(keys::INTERNAL_THREAD_ID, serde_json::json!("main"));
assert_eq!(ctx.thread_id(), Some("main".to_string()));
}
#[test]
fn parallel_ids_default() {
let ctx = Context::new();
assert_eq!(ctx.parallel_group_id(), None);
assert_eq!(ctx.parallel_branch_id(), None);
}
#[test]
fn parallel_ids_set() {
let ctx = Context::new();
ctx.set(
keys::INTERNAL_PARALLEL_GROUP_ID,
serde_json::json!("fanout@2"),
);
ctx.set(
keys::INTERNAL_PARALLEL_BRANCH_ID,
serde_json::json!("fanout@2:1"),
);
assert_eq!(ctx.parallel_group_id(), Some(StageId::new("fanout", 2)));
assert_eq!(
ctx.parallel_branch_id(),
Some(ParallelBranchId::new(StageId::new("fanout", 2), 1))
);
}
#[test]
fn node_visit_count_default() {
let ctx = Context::new();
// fabro-core returns 0 for missing; workflow code expects 1 as default
// when used in workflow context. The raw core accessor returns 0.
assert_eq!(ctx.node_visit_count(), 0);
}
#[test]
fn node_visit_count_set() {
let ctx = Context::new();
ctx.set(keys::INTERNAL_NODE_VISIT_COUNT, serde_json::json!(3));
assert_eq!(ctx.node_visit_count(), 3);
}
#[test]
fn current_node_id_default() {
let ctx = Context::new();
assert_eq!(ctx.current_node_id(), "");
}
#[test]
fn current_node_id_set() {
let ctx = Context::new();
ctx.set(keys::CURRENT_NODE, serde_json::json!("plan"));
assert_eq!(ctx.current_node_id(), "plan");
}
}