fabro/lib/crates/fabro-cli/tests/it
Bryan Helmkamp 48eb5efed6
refactor(archive): consolidate helpers after review
Three cleanups from `/simplify` review:

- Promote `archived_rejection_message` and `ensure_not_archived` to `pub`
  via operations/mod.rs and reuse them from `resume`, the CLI rewind
  caller, and the server's `reject_if_archived` guard so the canonical
  error string lives in exactly one place.
- Tighten `RewindInput.current_status` from `Option<RunStatus>` to
  `RunStatus`. The runtime check for None was enforcing a compile-time
  invariant. CLI callers already load the projection and now surface a
  clean error up-front if it's missing. Drop the None-branch test that
  existed only to cover the removed runtime check.
- Collapse `archive_run` / `unarchive_run` HTTP handlers into a shared
  `run_archive_action` body with an `ArchiveAction` enum, mirroring the
  CLI pattern. Removes ~20 lines of copy-paste and unifies error-mapping.

Also drop narrative comments that referenced plan unit numbers in the
scenario tests, and clean up the convoluted `ps_runs` helper pattern
that built an empty-slot arg vec before filling it in.

No behavior change. Full workspace: 4185 tests pass, clippy clean.
2026-04-19 18:14:16 -04:00
..
cmd polish: clarify -a hint, test archived status in web UI, tighten rewind input 2026-04-19 17:43:00 -04:00
scenario refactor(archive): consolidate helpers after review 2026-04-19 18:14:16 -04:00
support test: preserve LLVM_PROFILE_FILE across env_clear in CLI tests 2026-04-18 15:05:32 -04:00
workflow ci: switch clippy to pinned nightly, clean up workspace lints 2026-04-16 18:59:11 -04:00
main.rs chore(lint): fix all clippy warnings including --tests 2026-04-10 10:16:24 -04:00