mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-06 08:18:58 +00:00
47954f731e
Consolidate the copies that review found across the feature: - One GITHUB_CREDENTIAL_HELPER / GITHUB_CREDENTIAL_HELPER_KEY pair in fabro-github, with apply_probe_git_env() for probe commands; the runtime git bridge, server preflight probe, and live contract test all consume it so the probes exercise exactly what the bridge configures. - GitHubRepositoryAccess::resolve_verified_token() owns the resolve-installations-then-mint choreography shared by server preflight, workflow initialization, and the live test. - A shared lookup_installation() helper backs both the shared-installation resolution and the mint's installation lookup. - The contents = read|write rule lives once as RunIntegrationsGithubSettings::contents_permission_allows_repository_access. - The preflight probe paces retries with fabro-sandbox's exported replication_backoff() (3s/9s) instead of a contradicting 1s/2s loop, and shares one run_ls_remote() runner with the existing remote-ref check. Also: collapse the dead Ok(None) arm and repeated error blocks in the preflight token check, drop the derivable bridge_entry_count(), privatize resolve_permissions() behind resolve_integration(), make GitHubRepositorySlug ordering/hashing allocation-free, and use EnvVars constants for env names. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| testdata | ||
| access.rs | ||
| lib.rs | ||
| test_support.rs | ||
| tests_mock.rs | ||
| token_source.rs | ||