mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-06 02:48:25 +00:00
## Summary
Ports the validated `/chats/new` and `/chats/:id` chat surface from
`docs/superpowers/prototypes/2026-05-16-chats-new/` into
`apps/fabro-web`. Client-side scripted prototype mounted inside the
existing `AppShell`; replaces `/start` as the planned new "kick off
agent work" entry point (but does not delete `/start` in this phase).
- New routes: `/chats/new` (empty-state composer) and `/chats/:chatId`
(active conversation with assistant-ui's `<Thread>`, scripted streaming
replies, markdown + tool-call rendering).
- Drives `@assistant-ui/react` + `@assistant-ui/react-ui` via
`useLocalRuntime` and a custom `ChatModelAdapter` that cycles a 6-entry
scripted reply bank.
- Tailwind v4 cascade fix: assistant-ui CSS is now imported via `@layer
assistant-ui` so v4 utilities cascade above the package's unlayered
scoped preflight. Includes a discovered Bun-specific tweak — see Notable
Deviations below.
- StrictMode-safe first-message handoff: store seeds the user message
into `seedMessages` with a `pendingResponse: true` flag, and
`chats-detail` triggers a single `runtime.thread.startRun({ parentId:
null })` then consumes the flag. Avoids the prototype's
autorespond-lost-stream race under React 19 StrictMode.
The Ask-Fabro right sidebar (also in the prototype) is **out of scope**
for this PR.
Companion spec:
[`docs/superpowers/specs/2026-05-16-chats-new-prototype-design.md`](../tree/chats-new-port/docs/superpowers/specs/2026-05-16-chats-new-prototype-design.md)
Implementation plan:
[`docs/superpowers/plans/2026-05-16-chats-new-fabro-web-port.md`](../tree/chats-new-port/docs/superpowers/plans/2026-05-16-chats-new-fabro-web-port.md)
## Screenshots
Captured from a local debug `fabro server` running this branch's binary,
signed in via GitHub.
### `/chats/new` (empty state)

### `/chats/:chatId` (active conversation)

## Files
**New** (under `apps/fabro-web/`):
- `app/lib/chats-types.ts` — `Chat` wrapper + `ChatContentPart`
discriminated union over the API client's `CompletionContentPart`
- `app/lib/chats-script.ts` — 6-entry scripted reply bank
(`CompletionMessage[]`)
- `app/lib/chats-store.tsx` — Context + `useReducer` for chat metadata,
`pendingResponse` flag, scriptIndex
- `app/lib/chats-runtime.ts` — `createScriptedAdapter` +
`toThreadMessages` boundary converter
- `app/lib/test-utils.tsx` — minimal `renderHook` shim (lifts the
duplicated `IS_REACT_ACT_ENVIRONMENT` + dep-warning silencing pattern
out of `install-app.test.tsx`)
-
`app/components/chats/{tool-fallback,composer-chips,custom-composer}.tsx`
- `app/routes/{chats-layout,chats-new,chats-detail}.tsx`
- Tests: `chats-store.test.tsx` (5), `chats-runtime.test.ts` (4),
`chats-router.test.tsx` (3)
**Modified:**
- `package.json` — adds `@assistant-ui/{react,react-ui,react-markdown}`
(pinned exactly to versions verified in the prototype)
- `app/app.css` — `@layer` declaration + assistant-ui CSS imports into
`layer(assistant-ui)` + `.fabro-chat` `--aui-*` variable overrides
mapping to the Fabro palette
- `app/root.tsx` — removed `import "./app.css"` (see Notable Deviations)
- `app/router.tsx` — wires the chats routes under the AppShell tree
## Notable deviations from the plan
Two intentional deviations, both explained in their commit bodies:
1. **`apps/fabro-web/app/root.tsx` no longer imports `./app.css`.**
Bun's CSS bundler (used by `Bun.build` on `entry.tsx`) rejects
spec-valid `@layer name, name;` ordering between `@import` rules, even
though Tailwind's CLI accepts it. The CSS is built standalone by the
Tailwind CLI step in `scripts/build.ts` and linked from
`index.template.html`, so dropping the JS-side import bypasses Bun's
parser without any runtime change. A safety-net comment at the top of
`app.css` warns future engineers against re-adding the import. Commit:
`c37690be9`.
2. **`!` non-null assertions removed** in two places where the verbatim
prototype copy violated the global CLAUDE.md rule banning `!` in
production code: `chats-script.ts` now uses a typed `FALLBACK_REPLY` and
`??` coalescing; `composer-chips.tsx` lifts the first option of each
chip into a `DEFAULT_*` constant. `chats-runtime.test.ts`'s `for await`
drain loops were also replaced with `Array.fromAsync(...)` per the
no-loops-in-tests rule. Commits: `ace6ac6d4`, `652ad97af`.
## Test plan
- [x] `cd apps/fabro-web && bun run typecheck` — clean
- [x] `bun test` — 383 pass / 0 fail (12 new tests for chats)
- [x] `cd apps/fabro-web && bun run build` — succeeds; assistant-ui CSS
bundled into `dist/assets/app.css`
- [x] **Manual browser smoke test** — debug `fabro` binary running this
branch served `/chats/new` and `/chats/seed_email` correctly inside the
real AppShell with GitHub-OAuth auth (screenshots above).
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
126 lines
3.5 KiB
TypeScript
126 lines
3.5 KiB
TypeScript
import type {
|
|
ChatModelAdapter,
|
|
ChatModelRunResult,
|
|
ThreadAssistantMessagePart,
|
|
ThreadMessageLike,
|
|
} from "@assistant-ui/react";
|
|
|
|
import type { Chat, ChatContentPart, ChatMessage } from "./chats-types";
|
|
import { pickReply } from "./chats-script";
|
|
|
|
const STREAM_CHUNK_CHARS = 28;
|
|
const STREAM_CHUNK_INTERVAL_MS = 55;
|
|
|
|
function sleep(ms: number, signal: AbortSignal): Promise<void> {
|
|
return new Promise((resolve, reject) => {
|
|
if (signal.aborted) {
|
|
reject(new DOMException("Aborted", "AbortError"));
|
|
return;
|
|
}
|
|
const handle = setTimeout(resolve, ms);
|
|
signal.addEventListener(
|
|
"abort",
|
|
() => {
|
|
clearTimeout(handle);
|
|
reject(new DOMException("Aborted", "AbortError"));
|
|
},
|
|
{ once: true },
|
|
);
|
|
});
|
|
}
|
|
|
|
function toAssistantParts(
|
|
content: readonly ChatContentPart[],
|
|
): ThreadAssistantMessagePart[] {
|
|
const out: ThreadAssistantMessagePart[] = [];
|
|
for (const part of content) {
|
|
if (part.kind === "text") {
|
|
out.push({ type: "text", text: part.data.text });
|
|
} else if (part.kind === "tool_call") {
|
|
out.push({
|
|
type: "tool-call",
|
|
toolCallId: part.data.tool_call_id,
|
|
toolName: part.data.name,
|
|
args: part.data.arguments,
|
|
argsText: JSON.stringify(part.data.arguments),
|
|
});
|
|
} else if (part.kind === "tool_result") {
|
|
for (let i = out.length - 1; i >= 0; i--) {
|
|
const candidate = out[i];
|
|
if (
|
|
candidate?.type === "tool-call" &&
|
|
candidate.toolCallId === part.data.tool_call_id
|
|
) {
|
|
out[i] = { ...candidate, result: part.data.content };
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return out;
|
|
}
|
|
|
|
export function createScriptedAdapter(args: {
|
|
getChat: () => Chat | undefined;
|
|
onReplyComplete: (reply: ChatMessage) => void;
|
|
}): ChatModelAdapter {
|
|
return {
|
|
async *run({ abortSignal }) {
|
|
const chat = args.getChat();
|
|
const reply = pickReply(chat?.scriptIndex ?? 0);
|
|
const accumulated: ChatContentPart[] = [];
|
|
|
|
for (const part of reply.content) {
|
|
if (part.kind === "text") {
|
|
const text = part.data.text;
|
|
let cursor = 0;
|
|
accumulated.push({ kind: "text", data: { text: "" } });
|
|
const accIndex = accumulated.length - 1;
|
|
while (cursor < text.length) {
|
|
cursor = Math.min(cursor + STREAM_CHUNK_CHARS, text.length);
|
|
accumulated[accIndex] = {
|
|
kind: "text",
|
|
data: { text: text.slice(0, cursor) },
|
|
};
|
|
yield buildUpdate(accumulated);
|
|
if (cursor < text.length) {
|
|
await sleep(STREAM_CHUNK_INTERVAL_MS, abortSignal);
|
|
}
|
|
}
|
|
} else {
|
|
accumulated.push(part);
|
|
yield buildUpdate(accumulated);
|
|
await sleep(STREAM_CHUNK_INTERVAL_MS * 3, abortSignal);
|
|
}
|
|
}
|
|
|
|
args.onReplyComplete(reply);
|
|
},
|
|
};
|
|
}
|
|
|
|
function buildUpdate(parts: ChatContentPart[]): ChatModelRunResult {
|
|
return { content: toAssistantParts(parts) };
|
|
}
|
|
|
|
export function toThreadMessages(
|
|
messages: readonly ChatMessage[],
|
|
): ThreadMessageLike[] {
|
|
return messages.map((msg) => {
|
|
if (msg.role === "user") {
|
|
return {
|
|
role: "user",
|
|
content: msg.content
|
|
.filter((p) => p.kind === "text")
|
|
.map((p) => ({ type: "text", text: p.data.text }) as const),
|
|
};
|
|
}
|
|
if (msg.role === "assistant") {
|
|
return {
|
|
role: "assistant",
|
|
content: toAssistantParts(msg.content),
|
|
};
|
|
}
|
|
return { role: "system", content: [] };
|
|
});
|
|
}
|