fabro/lib/crates/fabro-server/tests/it/api
Bryan Helmkamp 328bddea33
fix(install): pass GitHub App manifest state as form field, not URL query
GitHub's App Manifest endpoint rejects `redirect_url` values that carry a
query string with "invalid redirect_uri", leaving the web wizard stuck:
the 10-minute pending-setup guard then blocked every retry for ten
minutes. Move the CSRF state out of `redirect_url` and into a hidden
`state` form field on the auto-submit — GitHub preserves it on the
callback, matching the CLI's working Manifest flow. Drop the retry
conflict so a fresh POST to /install/github/app/manifest always replaces
the pending entry and mints a new state token; stale callbacks are
already rejected by the existing state-match check on the redirect
handler.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 14:21:33 -04:00
..
cli_auth_config.rs feat(auth): add CLI GitHub login and logout flow 2026-04-20 07:12:52 -04:00
cli_auth_token.rs feat(auth): add CLI GitHub login and logout flow 2026-04-20 07:12:52 -04:00
docs.rs refactor(server): simplify github webhook wiring 2026-04-20 07:32:38 -04:00
install.rs fix(install): pass GitHub App manifest state as form field, not URL query 2026-04-21 14:21:33 -04:00
install_openai_compatible.rs test(http): improve HTTP test failure diagnostics 2026-04-20 08:06:14 -04:00
mod.rs feat(auth): add CLI GitHub login and logout flow 2026-04-20 07:12:52 -04:00
routing.rs fix(auth): harden loopback checks and align CSP tests 2026-04-20 13:30:45 -04:00
run_files.rs test(http): improve HTTP test failure diagnostics 2026-04-20 08:06:14 -04:00
runs.rs test(http): improve HTTP test failure diagnostics 2026-04-20 08:06:14 -04:00
settings.rs test(http): improve HTTP test failure diagnostics 2026-04-20 08:06:14 -04:00
system.rs test(http): improve HTTP test failure diagnostics 2026-04-20 08:06:14 -04:00
tcp.rs Merge remote-tracking branch 'origin/main' 2026-04-20 09:47:47 -04:00