Bryan Helmkamp 30fcee98c2 refactor(events): type stage/parallel ids with newtypes ... Promote RunEvent.stage_id / parallel_group_id / parallel_branch_id and the internal Event enum's matching fields from stringly-typed Option<String> to Option<StageId> / Option<ParallelBranchId>. The wire contract is now self-enforcing: malformed strings are rejected at the serde seam, not quietly round-tripped, and the three StageId::new(...).to_string() calls in stored_event_fields() just drop the .to_string() since the newtypes flow straight through. - fabro-types/src/stage_id.rs: new ParallelBranchId { group: StageId, index: u32 } mirroring StageId's Display / FromStr / serde string form. "{group}:{index}" (e.g. "fanout@2:0"). Tests for round-trip and parse rejections. - fabro-types/src/lib.rs: re-export ParallelBranchId. - fabro-types/src/run_event/mod.rs: RunEvent, RunEventRaw, and RunEventParts take Option<StageId> / Option<ParallelBranchId>. from_ref gains a small generic opt_field<T: Deserialize> helper that also replaces the bespoke actor null-handling branch. to_value uses serde_json::to_value(value) for the three typed fields. - fabro-workflow/src/event.rs: Event::Stage{Started,Completed, Failed,Retrying} and Event::Agent take Option<StageId> / Option<ParallelBranchId>. Event::ParallelBranch{Started,Completed} take the required (non-Option) typed forms. StoredEventFields and stored_event_fields() plumb the newtypes end-to-end. - fabro-workflow/src/context.rs: WorkflowContext::parallel_group_id() returns Option<StageId>, parallel_branch_id() returns Option<ParallelBranchId>. Read via serde_json::from_value which validates the shape on the way out. - fabro-workflow/src/handler/parallel.rs: builds typed values directly, stores in context via serde_json::to_value (still produces a JSON string through the custom Serialize). BranchSetup holds a ParallelBranchId. - fabro-workflow/src/handler/llm/api.rs: StageEventScope holds typed ids. - fabro-workflow/src/lifecycle/event.rs: stage_parallel_ids returns typed tuple. Wire JSON is byte-identical before and after (StageId serializes as "{node_id}@{visit}", ParallelBranchId as "{node_id}@{visit}:{index}", matching the existing spec). Progenitor-generated types and OpenAPI schema untouched. Existing None-only fixtures in runtime_store, git, pipeline, error, run_state, rewind, pr_view, and store/dump didn't need any edit because None fits any Option<T>. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>		2026-04-09 12:39:40 -04:00
..
crates	refactor(events): type stage/parallel ids with newtypes	2026-04-09 12:39:40 -04:00
packages/fabro-api-client	feat(api): flatten EventEnvelope wire JSON (schema v2)	2026-04-09 10:40:21 -04:00