mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-08 03:10:26 +00:00
176c0c0159
Three cleanups in one pass: 1. Bundle GitHub creds + base URL into a GitHubContext<'_>: Defined in fabro-github and threaded through create_pull_request, enable_auto_merge, get_pull_request, merge_pull_request, and close_pull_request (plus their _with_client variants). Each function loses its trailing `base_url: &str` and replaces `creds: &GitHubCredentials` with `ctx: GitHubContext<'_>`. Bundle propagates into OpenPullRequestRequest as a single `github` field instead of the prior split `creds` + `github_api_base_url`. 2. Delete dead CommandContext::storage_dir() and ::server_settings(): Origin added these for client-side PR commands that no longer exist after the server-side migration. Field `server_settings` removed from CommandContext (only the deleted method read it). Same field pruned from ResolvedCommandSettings; one test that verified the underlying loader behavior was rewired to read LoadedSettings directly via load_resolved_settings_from_toml. 3. Audit *_error helpers in fabro-server: no remaining single-use factories. The previous inlining pass left a tidy surface. No diff. Verified: workspace fmt clean, clippy --all-targets -D warnings clean, cargo nextest run --workspace 4587 passed, 182 skipped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fabro-agent | ||
| fabro-api | ||
| fabro-auth | ||
| fabro-checkpoint | ||
| fabro-cli | ||
| fabro-client | ||
| fabro-config | ||
| fabro-core | ||
| fabro-devcontainer | ||
| fabro-github | ||
| fabro-graphviz | ||
| fabro-hooks | ||
| fabro-http | ||
| fabro-install | ||
| fabro-interview | ||
| fabro-llm | ||
| fabro-macros | ||
| fabro-mcp | ||
| fabro-model | ||
| fabro-oauth | ||
| fabro-proc | ||
| fabro-retro | ||
| fabro-sandbox | ||
| fabro-server | ||
| fabro-slack | ||
| fabro-spa | ||
| fabro-store | ||
| fabro-telemetry | ||
| fabro-template | ||
| fabro-test | ||
| fabro-tracker | ||
| fabro-types | ||
| fabro-util | ||
| fabro-validate | ||
| fabro-vault | ||
| fabro-workflow | ||