mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-08-28 05:27:41 +00:00
9d3aa7a4d4
The lineage field's `skip_serializing_if` behavior was asserted five times across three crates. Keep the two assertions in fabro-types, which owns the attribute, and drop the duplicates: - Delete `run_created_omits_absent_workflow_version_id` from event/convert.rs, a copy of the test above it that re-checked another crate's serde attribute. convert.rs's own responsibility is covered by the existing field assertion. - Delete `legacy_create_input_persists_without_workflow_version_id`, which ran the full create() pipeline to prove a hardcoded `None` literal is `None`. `CreateRunInput` has no such field, so no input could change the result. - Fold `run_spec_omits_absent_workflow_version_id` into the adjacent legacy-spec test, which already holds an all-`None` record. - Drop the off-topic spec re-serialization from run_state.rs's retried_from test. Add `test_support::test_workflow_version_id()` alongside `test_run_provenance()` and use it everywhere, replacing eight copies of the same magic seed across five crates plus two assertion sites that recomputed the hash inline. This also subsumes retry.rs's private helper of the same shape. Revert the `run_spec_json` parameterization in the projection round-trip test: `RunProjection` is a `with_replacement` alias for the canonical type, so the `Some` and `None` call sites exercise identical code. Have the two run.created literals that mirror a `RunSpec` read the spec's lineage field instead of hardcoding `None`, so the mirrors stay accurate once a producer populates it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| build-support | ||
| fabro-api | ||
| fabro-auth | ||
| fabro-client | ||
| fabro-config | ||
| fabro-core | ||
| fabro-db | ||
| fabro-dev | ||
| fabro-http | ||
| fabro-macros | ||
| fabro-model | ||
| fabro-oauth | ||
| fabro-options-metadata | ||
| fabro-proc | ||
| fabro-redact | ||
| fabro-static | ||
| fabro-telemetry | ||
| fabro-template | ||
| fabro-test | ||
| fabro-types | ||
| fabro-util | ||
| fabro-vault | ||