mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-09 03:20:56 +00:00
0e703a7770
Apply cleanup review findings on the collector extraction: - Deduplicate the lexical path-normalization loop: normalize_absolute_path now delegates to lexically_normalize_access_path, and it plus manifest_path_from_absolute live in working_tree.rs so the module dependency points one way (projection -> collector). Drop the redundant re-normalization in collect_bundled_file. - Extract collect_bundled_template_includes to replace the copy-pasted goal/prompt template-closure sequence, seed_config_document for the duplicated config seeding, and read_source_input for the duplicated config reader closures (with the user-settings is_file check hoisted). - Replace ~100 lines of trivial getters on the Collected* output structs with pub(super) fields; keep the CollectedPath newtype encapsulated. - Assemble the manifest by value, moving collected sources into the wire types instead of deep-copying every file a second time; drop two full DraftDocument clones that only satisfied the borrow checker; stop recomputing manifest paths per file in template-dependency verification. - Resolve the root workflow once in assemble_current_manifest, removing an unreachable duplicate error path; flatten single-use CollectionNamespace into a finalize_documents free function. No behavior change; fabro-manifest tests, clippy, and fmt pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fabro-acp | ||
| fabro-agent | ||
| fabro-automation | ||
| fabro-checkpoint | ||
| fabro-dump | ||
| fabro-environment | ||
| fabro-github | ||
| fabro-graphviz | ||
| fabro-hooks | ||
| fabro-install | ||
| fabro-interview | ||
| fabro-llm | ||
| fabro-manifest | ||
| fabro-mcp | ||
| fabro-mcp-store | ||
| fabro-sandbox | ||
| fabro-slack | ||
| fabro-store | ||
| fabro-tool | ||
| fabro-tracker | ||
| fabro-validate | ||
| fabro-variable | ||
| fabro-workflow | ||