mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-01 02:04:24 +00:00
09fe367004
## Summary
`fabro model test` (CLI) probes every configured model with a cheap "Say
OK" prompt and prints a results table. Until now, the equivalent on
`/settings/models` was "open a terminal." This PR adds a single **Test
models** button in the section header that runs the same sweep against
the visible rows and renders per-row results inline. Wire format is the
existing `POST /api/v1/models/{id}/test` — no backend changes.
## Behavior
- One button beside the provider filter + search. Tests *whatever the
table currently shows* (filter + search applied at click time).
- Concurrency cap of 4 to mirror the CLI's `--jobs 4` default.
- Rows render `Queued` → `Testing…` → `Ok` (mint check) or red X +
truncated error (full message on hover via `title`).
- After each sweep, a small `N ok · M failed` chip appears next to the
button (mint when clean, coral on failures).
- Re-clicking starts a fresh sweep over the current view.
## Out of scope (deliberately)
- **No deep-test toggle** — page calls basic mode only; `fabro model
test --deep` still covers that case from the CLI.
- **No per-row Test button** — the page-level sweep replaces it.
- No cancellation, no result persistence across navigation/refresh, no
toast — the inline state *is* the feedback.
## Files
- `apps/fabro-web/app/routes/settings-models.tsx` — `RowState`/`Sweep`
types, `runSweep` worker pool, header button + summary chip, new "Test"
column, `TestStatusCell` component.
- `apps/fabro-web/app/components/state.tsx` — `Spinner` is now exported
(was previously private).
## Test plan
- Click "Test models" with several configured providers → rows flip in
waves of 4; summary lands as `N ok · 0 failed`.
- Revoke a provider's API key, click again → that provider's rows end in
red X with the upstream error in the cell (full text on hover).
- Apply a provider filter, click → only filtered rows test.
- DevTools Network panel → at most 4 in-flight `/models/<id>/test`
requests at any time.
---
[](https://github.com/EveryInc/compound-engineering-plugin)
🤖 Generated with Claude Opus 4.7 (1M context, extended thinking) via
[Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| chats | ||
| runs-list | ||
| stage-renderers | ||
| auth-layout.tsx | ||
| collapsible-file.tsx | ||
| editable-run-title.test.tsx | ||
| editable-run-title.tsx | ||
| event-debug-helpers.tsx | ||
| event-debug.tsx | ||
| graph-toolbar-constants.ts | ||
| graph-toolbar.tsx | ||
| hover-card-style.ts | ||
| icons.tsx | ||
| inline-markdown.test.tsx | ||
| inline-markdown.tsx | ||
| interview-dock.test.tsx | ||
| interview-dock.tsx | ||
| interview-label.ts | ||
| pull-request-chip.test.tsx | ||
| pull-request-chip.tsx | ||
| run-summary-panel.test.tsx | ||
| run-summary-panel.tsx | ||
| run-waterfall.tsx | ||
| settings-panel.tsx | ||
| size-chip.tsx | ||
| stage-context.tsx | ||
| stage-insights-sidebar.test.tsx | ||
| stage-insights-sidebar.tsx | ||
| stage-popover-summary.ts | ||
| stage-popover.test.tsx | ||
| stage-popover.tsx | ||
| stage-sidebar.test.tsx | ||
| stage-sidebar.tsx | ||
| state.tsx | ||
| steer-bar.tsx | ||
| terminal-view-helpers.ts | ||
| terminal-view.test.ts | ||
| terminal-view.tsx | ||
| toast.test.tsx | ||
| toast.tsx | ||
| ui.tsx | ||