fabro/lib/apps/fabro-cli/tests/it/scenario/smoke.rs
Bryan Helmkamp bc31b8d23a
Serve the run stream as the only run event API
Step 4 of the legacy executor deletion, third commit: the legacy event
API and every reader of it go, so that the next commits can delete the
event log, its reducer and the types beneath them.

The API:
- `GET /runs/{id}/events` pages the run stream only
  (`PaginatedRunStreamList` by `after`); the legacy `since_seq`,
  `before_seq` and `order` cursors, the `oneOf` envelope, the legacy
  `EventEnvelope`, `PaginatedEventList`, `RunEvent`, `EventSeq`,
  `AppendEventResponse` and `RunEventDetailResponse` schemas,
  `POST /runs/{id}/events`, `GET /runs/{id}/events/{seq}` and
  `GET /runs/{id}/stages/{stageId}/events` are deleted. `GET
  /runs/{id}/attach` and `GET /attach` frame `RunStreamItem`s only.
- The Rust and TypeScript clients regenerate; the removed models leave
  the TypeScript package.

The readers:
- `fabro-client` drops the legacy run event listing, tail and attach
  methods and `RunEventStream`; `list_run_stream_until` bounds a stream
  read.
- `fabro-tool`'s `fabro_run_events` lists, searches and details the run
  stream: `after` is the exclusive `stream_seq` cursor, `event_id` the
  item's id, filters match the item's name and `recorded_at`.
- `fabro-dump` writes the stream to `events.jsonl`; `fabro dump` reads
  it.
- The CLI's progress renderer keeps only what the run stream drives:
  the legacy event conversion, the sandbox and setup displays and their
  styles go. `fabro system events` prints stream items.
- The server's demo mode folds its agent fixture straight into the
  session projection and answers the attach stub with a stream item;
  the demo stage events endpoint is gone.
- The web app: every run is a Petri run. The legacy event hooks,
  renderer props, stage popover summary, run phases derivation and
  live-event payload handling are deleted or ported to `RunStreamItem`;
  toasts and board refreshes read the stream's platform records.
- Tests: the legacy API round trips and pagination tests are deleted;
  the CLI's MCP, attach and system event mocks serve stream pages; the
  CLI test helpers read stream items.

Still failing until the later commits: the CLI tests seeded through
`POST /runs/{id}/events`, the server tests over the legacy store, and
the legacy type tests.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-18 13:36:00 -04:00

315 lines
11 KiB
Rust

use fabro_test::{fabro_snapshot, test_context};
use httpmock::MockServer;
use crate::cmd::support::remote_run_summary_json;
use crate::support::{LightweightCli, run_projection_json, unique_run_id};
fn live_run_state_response(run_id: &str) -> serde_json::Value {
run_projection_json(
run_id,
&serde_json::json!({
"kind": "running"
}),
)
}
/// The platform record that moves the run to `status` (`running`,
/// `succeeded`, ...), as one item of the run's stream.
fn lifecycle_item(
run_id: &str,
stream_seq: u64,
transition: &str,
status: &str,
) -> serde_json::Value {
serde_json::json!({
"run_id": run_id,
"stream_seq": stream_seq,
"kind": "platform",
"id": stream_seq.to_string(),
"recorded_at": 1_775_390_400_000_u64 + stream_seq,
"item": {
"seq": stream_seq,
"recorded_at": 1_775_390_400_000_u64 + stream_seq,
"record": {
"kind": "run.lifecycle",
"transition": transition,
"status": { "kind": status, "reason": "completed" }
}
}
})
}
fn run_sse_body(run_id: &str) -> String {
let completed = lifecycle_item(run_id, 2, "succeeded", "succeeded");
format!("data: {completed}\n\n")
}
#[test]
fn help_smoke_covers_high_cost_commands() {
let cli = LightweightCli::new();
let mut artifact = cli.command();
artifact.args(["artifact", "--help"]);
fabro_snapshot!(artifact, @"
success: true
exit_code: 0
----- stdout -----
Inspect and copy run artifacts (screenshots, reports, traces)
Usage: fabro artifact [OPTIONS] <COMMAND>
Commands:
list List artifacts for a workflow run
cp Copy artifacts from a workflow run
help Print this message or the help of the given subcommand(s)
Options:
--json Output as JSON [env: FABRO_JSON=]
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
--quiet Suppress non-essential output [env: FABRO_QUIET=]
--verbose Enable verbose output [env: FABRO_VERBOSE=]
-h, --help Print help
----- stderr -----
");
let mut artifact_list = cli.command();
artifact_list.args(["artifact", "list", "--help"]);
fabro_snapshot!(artifact_list, @"
success: true
exit_code: 0
----- stdout -----
List artifacts for a workflow run
Usage: fabro artifact list [OPTIONS] <RUN_ID>
Arguments:
<RUN_ID> Run ID (or prefix)
Options:
--json Output as JSON [env: FABRO_JSON=]
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
--node <NODE> Filter to artifacts from a specific node
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
--stage <STAGE> Filter to artifacts from a specific stage visit (node@visit)
--quiet Suppress non-essential output [env: FABRO_QUIET=]
--retry <RETRY> Filter to artifacts from a specific retry attempt
--verbose Enable verbose output [env: FABRO_VERBOSE=]
-h, --help Print help
----- stderr -----
");
let mut artifact_cp = cli.command();
artifact_cp.args(["artifact", "cp", "--help"]);
fabro_snapshot!(artifact_cp, @"
success: true
exit_code: 0
----- stdout -----
Copy artifacts from a workflow run
Usage: fabro artifact cp [OPTIONS] <SOURCE> [DEST]
Arguments:
<SOURCE> Source: RUN_ID (all artifacts) or RUN_ID:path (specific artifact)
[DEST] Destination directory (defaults to current directory) [default: .]
Options:
--json Output as JSON [env: FABRO_JSON=]
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
--node <NODE> Filter to artifacts from a specific node
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
--stage <STAGE> Filter to artifacts from a specific stage visit (node@visit)
--quiet Suppress non-essential output [env: FABRO_QUIET=]
--retry <RETRY> Filter to artifacts from a specific retry attempt
--tree Preserve node[/visit_{N}]/retry_{N}/ directory structure
--verbose Enable verbose output [env: FABRO_VERBOSE=]
-h, --help Print help
----- stderr -----
");
let mut settings = cli.command();
settings.args(["settings", "--help"]);
fabro_snapshot!(settings, @"
success: true
exit_code: 0
----- stdout -----
Inspect effective settings
Usage: fabro settings [OPTIONS]
Options:
--json Output as JSON [env: FABRO_JSON=]
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
--quiet Suppress non-essential output [env: FABRO_QUIET=]
--verbose Enable verbose output [env: FABRO_VERBOSE=]
-h, --help Print help
----- stderr -----
");
let mut attach = cli.command();
attach.args(["attach", "--help"]);
fabro_snapshot!(attach, @"
success: true
exit_code: 0
----- stdout -----
Attach to a running or finished workflow run
Usage: fabro attach [OPTIONS] <RUN>
Arguments:
<RUN> Run ID prefix or workflow name
Options:
--json Output as JSON [env: FABRO_JSON=]
--server <SERVER> Fabro server target: http(s) URL or absolute Unix socket path [env: FABRO_SERVER=]
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
--quiet Suppress non-essential output [env: FABRO_QUIET=]
--verbose Enable verbose output [env: FABRO_VERBOSE=]
-h, --help Print help
----- stderr -----
");
}
#[test]
fn completion_smoke_covers_help_and_generation() {
let cli = LightweightCli::new();
let mut help = cli.command();
help.args(["completion", "--help"]);
fabro_snapshot!(help, @"
success: true
exit_code: 0
----- stdout -----
Generate shell completions
Usage: fabro completion [OPTIONS] <SHELL>
Arguments:
<SHELL> Shell to generate completions for [possible values: bash, elvish, fish, powershell, zsh]
Options:
--json Output as JSON [env: FABRO_JSON=]
--debug Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
--no-upgrade-check Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=true]
--quiet Suppress non-essential output [env: FABRO_QUIET=]
--verbose Enable verbose output [env: FABRO_VERBOSE=]
-h, --help Print help
----- stderr -----
");
let mut zsh = cli.command();
zsh.args(["completion", "zsh"]);
zsh.assert().success();
let mut fish = cli.command();
fish.args(["completion", "fish"]);
fish.assert().success();
}
#[test]
fn attach_smoke_covers_arg_validation_and_remote_server_behaviors() {
let context = test_context!();
let mut missing_arg = context.command();
missing_arg.arg("attach");
fabro_snapshot!(context.filters(), missing_arg, @"
success: false
exit_code: 2
----- stdout -----
----- stderr -----
error: the following required arguments were not provided:
<RUN>
Usage: fabro attach --no-upgrade-check <RUN>
For more information, try '--help'.
");
let success_server = MockServer::start();
let success_run_id = unique_run_id();
let resolve_mock = success_server.mock(|when, then| {
when.method("GET")
.path("/api/v1/runs/resolve")
.query_param("selector", success_run_id.as_str());
then.status(200)
.header("Content-Type", "application/json")
.body(
remote_run_summary_json(
&success_run_id,
"Remote Workflow",
"remote-workflow",
"Remote output",
&serde_json::json!({
"kind": "running"
}),
"2026-04-05T12:00:00Z",
)
.to_string(),
);
});
success_server.mock(|when, then| {
when.method("GET")
.path(format!("/api/v1/runs/{success_run_id}/events"))
.query_param("after", "0");
then.status(200)
.header("Content-Type", "application/json")
.body(
serde_json::json!({
"data": [lifecycle_item(&success_run_id, 1, "running", "running")],
"meta": { "has_more": false },
"event_contract_version": 3
})
.to_string(),
);
});
success_server.mock(|when, then| {
when.method("GET")
.path(format!("/api/v1/runs/{success_run_id}/state"));
then.status(200)
.header("Content-Type", "application/json")
.body(live_run_state_response(success_run_id.as_str()).to_string());
});
success_server.mock(|when, then| {
when.method("GET")
.path(format!("/api/v1/runs/{success_run_id}/questions"))
.query_param("page[limit]", "100")
.query_param("page[offset]", "0");
then.status(200)
.header("Content-Type", "application/json")
.body(r#"{"data":[],"meta":{"has_more":false}}"#);
});
let attach_mock = success_server.mock(|when, then| {
when.method("GET")
.path(format!("/api/v1/runs/{success_run_id}/attach"))
.query_param("after", "1");
then.status(200)
.header("Content-Type", "text/event-stream")
.body(run_sse_body(success_run_id.as_str()));
});
context.set_http_target(&success_server.base_url());
let success_output = context
.command()
.args(["--json", "attach", &success_run_id])
.output()
.expect("attach should execute");
assert!(
success_output.status.success(),
"attach failed:\nstdout:\n{}\nstderr:\n{}",
String::from_utf8_lossy(&success_output.stdout),
String::from_utf8_lossy(&success_output.stderr)
);
resolve_mock.assert();
attach_mock.assert();
let success_stdout = String::from_utf8(success_output.stdout).expect("stdout should be UTF-8");
assert!(
success_stdout.contains("\"transition\":\"succeeded\""),
"{success_stdout}"
);
}