mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-07 08:27:12 +00:00
## Summary Improves the web UI's React Doctor audit score by separating reusable helpers from React component modules, tightening effect/state ownership, and extracting real component boundaries in the install wizard, stage activity view, run-files diff browser, RunDetail route, and Runs workspace. The branch removes the previously deferred RunDetail and Runs giant-component diagnostics without changing RunDetail UX, route contracts, action ordering, or Runs workspace behavior. | Metric | Main baseline | Initial PR | Current PR | |--------|---------------|------------|------------| | React Doctor score | 63 | 71 | 99 | | React Doctor errors | 123 | 0 | 0 | | React Doctor warnings | 241 | 163 | 3 | | React Doctor diagnostics | 364 | 163 | 3 | ## Changes - Moves exported helper logic out of component files so Fast Refresh/component-export rules no longer dominate the audit. - Adds a targeted React Doctor config exception for React Router route modules, where non-component exports like route metadata are intentional. - Refactors low-risk state/effect patterns: keyed interview question state, reducer-backed editable run title state, event-owned preview opening, route-keyed insights editor initialization, refresh timer ownership, and selection/derived list cleanup. - Reworks `InstallApp` around an install reducer, a controller hook for install lifecycle state, and focused wizard step components for LLM, server, object-store, sandbox, and GitHub setup. - Moves `RunStages` selected-stage activity into a keyed boundary for panel/debug detail state while preserving stage activity filters across navigation. - Extracts the `RunFiles` loaded diff-browser view from route/query coordination so the route owns data/URL state and the loaded view owns rendering. - Splits `RunDetail` into route-local header, actions, tab shell, docked controls, model, and lifecycle-toast modules; the actions menu now uses grouped descriptors instead of a large boolean/callback prop matrix. - Extracts Runs workspace preference ownership into `useRunsWorkspacePreferences` and moves toolbar rendering into `RunsToolbar`, leaving the route focused on data, DnD state, filtering, and view selection. - Guards `InsightsEditor` query execution with a latest-run id and timeout cleanup so stale or unmounted mock query runs cannot overwrite newer results. - Adds regression coverage for archived-run deletion from RunDetail and stale-result handling in InsightsEditor. - Improves semantic/accessibility coverage with labeled controls, native meter/section semantics, decorative status dots, and clearer unavailable copy. - Removes dead UI code and applies local suppressions only where the rule is a documented false positive or an intentional imperative integration boundary. ## Remaining React Doctor warnings Current score is 99 with 0 errors and 3 warnings. The remaining warnings are intentionally left for separate judgment rather than mechanical churn: - `prefer-useReducer` (3): `AutomationsNew`, `InsightsEditor`, and `CreateSecretForm` need reducers only if they encode real coupled transitions, not simple field setters. ## Verification - `cd apps/fabro-web && bun test app/routes/run-detail.test.ts` -> `22 pass`, `0 fail` - `cd apps/fabro-web && bun test app/routes/insights-editor.test.tsx app/routes/runs.preferences.test.tsx` -> `7 pass`, `0 fail` - `cd apps/fabro-web && bun run typecheck` - `cd apps/fabro-web && bun test --isolate` -> `490 pass`, `0 fail` - `cd apps/fabro-web && bunx react-doctor@latest --full --json > /tmp/fabro-react-doctor-runs-insights.json` -> score `99`, `0` errors, `3` warnings - Earlier branch verification also included `cd apps/fabro-web && bun run build` - `git diff --check` --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with GPT-5 (context not reported, default reasoning) via [Codex](https://openai.com/codex)
60 lines
1.6 KiB
TypeScript
60 lines
1.6 KiB
TypeScript
import { useMemo, type ReactNode } from "react";
|
|
import { Lexer, type Token } from "marked";
|
|
|
|
const CODE_CLASSNAME =
|
|
"rounded bg-overlay-strong px-1 py-0.5 font-mono text-[0.85em] text-fg-2";
|
|
|
|
function tokenKey(token: Token, index: number): string {
|
|
const raw = "raw" in token ? token.raw : "";
|
|
return `${token.type}:${raw}:${index}`;
|
|
}
|
|
|
|
function TokenList({ tokens }: { tokens: Token[] }) {
|
|
return (
|
|
<>
|
|
{tokens.map((token, index) => (
|
|
<TokenNode key={tokenKey(token, index)} token={token} />
|
|
))}
|
|
</>
|
|
);
|
|
}
|
|
|
|
function TokenNode({ token }: { token: Token }): ReactNode {
|
|
switch (token.type) {
|
|
case "codespan":
|
|
return <code className={CODE_CLASSNAME}>{token.text}</code>;
|
|
case "strong":
|
|
return <strong><TokenList tokens={token.tokens} /></strong>;
|
|
case "em":
|
|
return <em><TokenList tokens={token.tokens} /></em>;
|
|
case "del":
|
|
return <TokenList tokens={token.tokens} />;
|
|
case "link":
|
|
return token.tokens.length > 0 ? <TokenList tokens={token.tokens} /> : token.text;
|
|
case "image":
|
|
return token.text;
|
|
case "html":
|
|
return token.raw;
|
|
case "br":
|
|
return " ";
|
|
case "escape":
|
|
return token.text;
|
|
case "text":
|
|
return token.tokens && token.tokens.length > 0
|
|
? <TokenList tokens={token.tokens} />
|
|
: token.text;
|
|
default:
|
|
return "raw" in token ? token.raw : "";
|
|
}
|
|
}
|
|
|
|
export function InlineMarkdown({
|
|
content,
|
|
className,
|
|
}: {
|
|
content: string;
|
|
className?: string;
|
|
}) {
|
|
const tokens = useMemo(() => Lexer.lexInline(content), [content]);
|
|
return <span className={className}><TokenList tokens={tokens} /></span>;
|
|
}
|