mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-09 03:20:56 +00:00
## Summary Moves provider-specific facts out of `AdapterKind` metadata and into provider catalog data, leaving adapters responsible for runtime protocol behavior. This makes providers that share an adapter mostly TOML-driven while still surfacing adapter construction failures during readiness checks. ## What Changed - Provider TOML now owns auth mode, API-key/header policy, billing policy, agent profile, base URLs/env overrides, extra headers, and probe markers. - Auth, install, config, diagnostics, and server flows resolve provider credentials from catalog auth config, including API-key, header-only, and no-auth providers. - LLM client registration now reports adapter construction failures, validates final adapter requests before HTTP dispatch, and preserves custom primary auth headers. - Billing and docs now use provider-owned billing policy instead of adapter metadata, and the old adapter metadata surface is removed. ## Reviewer Notes OpenAI-compatible `base_url` validation now happens during adapter/client registration rather than catalog build. That keeps catalog parsing adapter-agnostic while still letting readiness and model listing reflect providers that cannot register. ## Verification - `cargo check -p fabro-model -p fabro-auth -p fabro-llm -p fabro-server -p fabro-cli` - `cargo nextest run -p fabro-llm -- adapter_registry` - `cargo nextest run -p fabro-model -- catalog` - `cargo nextest run -p fabro-auth -- api_key` - `cargo nextest run -p fabro-server -- install` - `cargo +nightly-2026-04-14 fmt --check --all` --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with GPT-5 via [Codex](https://openai.com/codex) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
275 lines
9.4 KiB
Rust
275 lines
9.4 KiB
Rust
#![expect(
|
|
clippy::disallowed_methods,
|
|
reason = "Live provider integration tests read required API keys from process env."
|
|
)]
|
|
|
|
use std::sync::Arc;
|
|
|
|
use fabro_llm::error::ProviderErrorKind;
|
|
use fabro_llm::provider::ProviderAdapter;
|
|
use fabro_llm::providers::{AnthropicAdapter, GeminiAdapter, OpenAiAdapter};
|
|
use fabro_llm::types::{FinishReason, Message, Request};
|
|
use fabro_model::Catalog;
|
|
use fabro_static::EnvVars;
|
|
|
|
fn make_request(model: &str) -> Request {
|
|
Request {
|
|
model: model.to_string(),
|
|
messages: vec![Message::user("Say hello in exactly one word")],
|
|
provider: None,
|
|
tools: None,
|
|
tool_choice: None,
|
|
response_format: None,
|
|
temperature: Some(0.0),
|
|
top_p: None,
|
|
max_tokens: Some(50),
|
|
stop_sequences: None,
|
|
reasoning_effort: None,
|
|
speed: None,
|
|
metadata: None,
|
|
provider_options: None,
|
|
}
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("ANTHROPIC_API_KEY"))]
|
|
async fn anthropic_complete() {
|
|
let api_key = std::env::var(EnvVars::ANTHROPIC_API_KEY).expect("ANTHROPIC_API_KEY must be set");
|
|
let adapter = AnthropicAdapter::new(api_key);
|
|
let request = make_request("claude-haiku-4-5");
|
|
let response = adapter.complete(&request).await.unwrap();
|
|
|
|
assert!(
|
|
!response.text().is_empty(),
|
|
"response text should not be empty"
|
|
);
|
|
assert_eq!(response.finish_reason, FinishReason::Stop);
|
|
assert!(response.usage.input_tokens > 0);
|
|
assert!(response.usage.output_tokens > 0);
|
|
assert_eq!(response.provider, "anthropic");
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(twin, live("OPENAI_API_KEY"))]
|
|
async fn openai_complete() {
|
|
let (base_url, api_key) = fabro_test::e2e_openai!();
|
|
let adapter = OpenAiAdapter::new(api_key).with_base_url(base_url);
|
|
let request = Request {
|
|
temperature: None,
|
|
..make_request("gpt-5.2")
|
|
};
|
|
let response = adapter.complete(&request).await.unwrap();
|
|
|
|
assert!(
|
|
!response.text().is_empty(),
|
|
"response text should not be empty"
|
|
);
|
|
assert_eq!(response.finish_reason, FinishReason::Stop);
|
|
assert!(response.usage.input_tokens > 0);
|
|
assert!(response.usage.output_tokens > 0);
|
|
assert_eq!(response.provider, "openai");
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(twin, live("OPENAI_API_KEY"))]
|
|
async fn openai_gpt_5_3_codex_complete() {
|
|
let (base_url, api_key) = fabro_test::e2e_openai!();
|
|
let adapter = OpenAiAdapter::new(api_key).with_base_url(base_url);
|
|
let request = make_request("gpt-5.3-codex");
|
|
let response = adapter.complete(&request).await.unwrap();
|
|
|
|
assert!(
|
|
!response.text().is_empty(),
|
|
"response text should not be empty"
|
|
);
|
|
assert!(response.usage.input_tokens > 0);
|
|
assert!(response.usage.output_tokens > 0);
|
|
assert_eq!(response.provider, "openai");
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("OPENAI_API_KEY"))]
|
|
async fn openai_gpt_5_5_complete() {
|
|
let api_key = std::env::var(EnvVars::OPENAI_API_KEY).expect("OPENAI_API_KEY must be set");
|
|
let adapter = OpenAiAdapter::new(api_key);
|
|
let request = Request {
|
|
temperature: None,
|
|
..make_request("gpt-5.5")
|
|
};
|
|
let response = adapter.complete(&request).await.unwrap();
|
|
|
|
assert!(
|
|
!response.text().is_empty(),
|
|
"response text should not be empty"
|
|
);
|
|
assert!(response.usage.input_tokens > 0);
|
|
assert!(response.usage.output_tokens > 0);
|
|
assert_eq!(response.provider, "openai");
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("OPENAI_GPT_5_5_PRO_API_KEY"))]
|
|
async fn openai_gpt_5_5_pro_complete() {
|
|
let api_key = std::env::var("OPENAI_GPT_5_5_PRO_API_KEY")
|
|
.expect("OPENAI_GPT_5_5_PRO_API_KEY must be set");
|
|
let adapter = OpenAiAdapter::new(api_key);
|
|
let request = Request {
|
|
temperature: None,
|
|
..make_request("gpt-5.5-pro")
|
|
};
|
|
let response = adapter.complete(&request).await.unwrap();
|
|
|
|
assert!(
|
|
!response.text().is_empty(),
|
|
"response text should not be empty"
|
|
);
|
|
assert!(response.usage.input_tokens > 0);
|
|
assert!(response.usage.output_tokens > 0);
|
|
assert_eq!(response.provider, "openai");
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(twin)]
|
|
async fn openai_server_error() {
|
|
let (base_url, api_key) = fabro_test::e2e_openai!();
|
|
let admin_url = base_url
|
|
.strip_suffix("/v1")
|
|
.expect("OpenAI base URL should end with /v1");
|
|
|
|
fabro_test::test_http_client()
|
|
.post(format!("{admin_url}/__admin/scenarios"))
|
|
.bearer_auth(&api_key)
|
|
.json(&serde_json::json!({
|
|
"scenarios": [{
|
|
"matcher": { "endpoint": "responses" },
|
|
"script": {
|
|
"kind": "error",
|
|
"status": 500,
|
|
"message": "internal server error",
|
|
"error_type": "server_error",
|
|
"code": "server_error"
|
|
}
|
|
}]
|
|
}))
|
|
.send()
|
|
.await
|
|
.unwrap();
|
|
|
|
let adapter = OpenAiAdapter::new(api_key).with_base_url(base_url);
|
|
let request = make_request("gpt-4o-mini");
|
|
let err = adapter.complete(&request).await.unwrap_err();
|
|
|
|
assert_eq!(err.provider_kind(), Some(ProviderErrorKind::Server));
|
|
assert_eq!(err.status_code(), Some(500));
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("GEMINI_API_KEY"))]
|
|
async fn gemini_complete() {
|
|
let api_key = std::env::var(EnvVars::GEMINI_API_KEY).expect("GEMINI_API_KEY must be set");
|
|
let adapter = GeminiAdapter::new(api_key);
|
|
let request = make_request("gemini-2.5-flash");
|
|
let response = adapter.complete(&request).await.unwrap();
|
|
|
|
assert!(
|
|
!response.text().is_empty(),
|
|
"response text should not be empty"
|
|
);
|
|
assert_eq!(response.finish_reason, FinishReason::Stop);
|
|
assert!(response.usage.input_tokens > 0);
|
|
assert!(response.usage.output_tokens > 0);
|
|
assert_eq!(response.provider, "gemini");
|
|
}
|
|
|
|
async fn run_multi_turn_cache_test(
|
|
adapter: &dyn ProviderAdapter,
|
|
model: &str,
|
|
min_cache_ratio: f64,
|
|
temperature: Option<f64>,
|
|
) {
|
|
// Claude Haiku 4.5 requires 4096 tokens minimum for prompt caching.
|
|
// Each repeat is ~78 tokens; 70 repeats ≈ 5460 tokens, safely above the
|
|
// threshold.
|
|
let padding = "This is a detailed context paragraph that provides background information \
|
|
about the conversation. It contains various facts and details that the model should \
|
|
remember throughout the multi-turn interaction. The purpose of this padding is to \
|
|
ensure the system prompt exceeds the minimum cache threshold for the provider. \
|
|
We include information about mathematics, science, history, and general knowledge. \
|
|
The model should use this context when answering questions. "
|
|
.repeat(70);
|
|
|
|
let system_message = Message::system(format!(
|
|
"You are a helpful math assistant. Answer briefly.\n\n{padding}"
|
|
));
|
|
|
|
let questions = [
|
|
"What is 1+1?",
|
|
"What is 2+2?",
|
|
"What is 3+3?",
|
|
"What is 4+4?",
|
|
"What is 5+5?",
|
|
"What is 6+6?",
|
|
];
|
|
|
|
let mut messages = vec![system_message, Message::user(questions[0])];
|
|
let mut best_cache_ratio = 0.0_f64;
|
|
|
|
for turn in 0..6 {
|
|
let request = Request {
|
|
model: model.to_string(),
|
|
messages: messages.clone(),
|
|
provider: None,
|
|
tools: None,
|
|
tool_choice: None,
|
|
response_format: None,
|
|
temperature,
|
|
top_p: None,
|
|
max_tokens: Some(100),
|
|
stop_sequences: None,
|
|
reasoning_effort: None,
|
|
speed: None,
|
|
metadata: None,
|
|
provider_options: None,
|
|
};
|
|
|
|
let response = adapter
|
|
.complete(&request)
|
|
.await
|
|
.expect("provider adapter should return a response");
|
|
let text = response.text();
|
|
assert!(
|
|
!text.is_empty(),
|
|
"response text should not be empty on turn {turn}"
|
|
);
|
|
|
|
let cache_read = response.usage.cache_read_tokens as f64;
|
|
let input = response.usage.input_tokens as f64;
|
|
let ratio = cache_read / input;
|
|
best_cache_ratio = best_cache_ratio.max(ratio);
|
|
|
|
messages.push(Message::assistant(text));
|
|
if turn < 5 {
|
|
messages.push(Message::user(questions[turn + 1]));
|
|
}
|
|
}
|
|
|
|
assert!(
|
|
best_cache_ratio >= min_cache_ratio,
|
|
"best cache ratio {best_cache_ratio:.3} should be at least {min_cache_ratio} across all turns"
|
|
);
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("ANTHROPIC_API_KEY"))]
|
|
async fn anthropic_multi_turn_cache() {
|
|
let api_key = std::env::var(EnvVars::ANTHROPIC_API_KEY).expect("ANTHROPIC_API_KEY must be set");
|
|
let adapter =
|
|
AnthropicAdapter::new(api_key).with_catalog(Arc::new(Catalog::from_builtin().unwrap()));
|
|
run_multi_turn_cache_test(&adapter, "claude-haiku-4-5", 0.5, Some(0.0)).await;
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("OPENAI_API_KEY"))]
|
|
async fn openai_multi_turn_cache() {
|
|
let api_key = std::env::var(EnvVars::OPENAI_API_KEY).expect("OPENAI_API_KEY must be set");
|
|
let adapter = OpenAiAdapter::new(api_key);
|
|
run_multi_turn_cache_test(&adapter, "gpt-5.2", 0.5, None).await;
|
|
}
|
|
|
|
#[fabro_macros::e2e_test(live("GEMINI_API_KEY"))]
|
|
async fn gemini_multi_turn_cache() {
|
|
let api_key = std::env::var(EnvVars::GEMINI_API_KEY).expect("GEMINI_API_KEY must be set");
|
|
let adapter = GeminiAdapter::new(api_key);
|
|
run_multi_turn_cache_test(&adapter, "gemini-2.5-flash", 0.5, Some(0.0)).await;
|
|
}
|