mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-29 06:36:51 +00:00
bc31b8d23a
Step 4 of the legacy executor deletion, third commit: the legacy event
API and every reader of it go, so that the next commits can delete the
event log, its reducer and the types beneath them.
The API:
- `GET /runs/{id}/events` pages the run stream only
(`PaginatedRunStreamList` by `after`); the legacy `since_seq`,
`before_seq` and `order` cursors, the `oneOf` envelope, the legacy
`EventEnvelope`, `PaginatedEventList`, `RunEvent`, `EventSeq`,
`AppendEventResponse` and `RunEventDetailResponse` schemas,
`POST /runs/{id}/events`, `GET /runs/{id}/events/{seq}` and
`GET /runs/{id}/stages/{stageId}/events` are deleted. `GET
/runs/{id}/attach` and `GET /attach` frame `RunStreamItem`s only.
- The Rust and TypeScript clients regenerate; the removed models leave
the TypeScript package.
The readers:
- `fabro-client` drops the legacy run event listing, tail and attach
methods and `RunEventStream`; `list_run_stream_until` bounds a stream
read.
- `fabro-tool`'s `fabro_run_events` lists, searches and details the run
stream: `after` is the exclusive `stream_seq` cursor, `event_id` the
item's id, filters match the item's name and `recorded_at`.
- `fabro-dump` writes the stream to `events.jsonl`; `fabro dump` reads
it.
- The CLI's progress renderer keeps only what the run stream drives:
the legacy event conversion, the sandbox and setup displays and their
styles go. `fabro system events` prints stream items.
- The server's demo mode folds its agent fixture straight into the
session projection and answers the attach stub with a stream item;
the demo stage events endpoint is gone.
- The web app: every run is a Petri run. The legacy event hooks,
renderer props, stage popover summary, run phases derivation and
live-event payload handling are deleted or ported to `RunStreamItem`;
toasts and board refreshes read the stream's platform records.
- Tests: the legacy API round trips and pagination tests are deleted;
the CLI's MCP, attach and system event mocks serve stream pages; the
CLI test helpers read stream items.
Still failing until the later commits: the CLI tests seeded through
`POST /runs/{id}/events`, the server tests over the legacy store, and
the legacy type tests.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
74 lines
2.2 KiB
TypeScript
74 lines
2.2 KiB
TypeScript
import { useEffect, useRef } from "react";
|
|
import type { RunStreamItem } from "@qltysh/fabro-api-client";
|
|
import type { Key } from "swr";
|
|
|
|
import {
|
|
subscribeToCrossTabSse,
|
|
type CrossTabSseCoordinator,
|
|
} from "./cross-tab-sse";
|
|
import { isStreamItemPayload } from "./petri-stream";
|
|
import { queryKeys } from "./query-keys";
|
|
import {
|
|
createBrowserEventSource,
|
|
subscribeToSharedEventSource,
|
|
type EventPayload,
|
|
type EventSourceLike,
|
|
type SharedEventSubscription,
|
|
} from "./sse";
|
|
|
|
interface LiveEventOptions {
|
|
coordinator?: CrossTabSseCoordinator;
|
|
}
|
|
|
|
const subscriptions = new Map<string, SharedEventSubscription>();
|
|
const SUBSCRIPTION_KEY = "live-events";
|
|
const NO_KEYS: Key[] = [];
|
|
const NOOP_MUTATE = () => Promise.resolve();
|
|
|
|
/**
|
|
* Every run stream item the global attach stream (`GET /api/v1/attach`)
|
|
* delivers, across all runs. A frame that is not a stream item is dropped.
|
|
*/
|
|
export function subscribeToLiveEvents(
|
|
onItem: (item: RunStreamItem) => void,
|
|
eventSourceFactory: (url: string) => EventSourceLike = createBrowserEventSource,
|
|
{ coordinator }: LiveEventOptions = {},
|
|
): () => void {
|
|
const forward = (payload: EventPayload) => {
|
|
if (isStreamItemPayload(payload)) onItem(payload);
|
|
return { keys: NO_KEYS };
|
|
};
|
|
return subscribeToCrossTabSse<EventPayload>({
|
|
coordinator,
|
|
subscriptionKey: SUBSCRIPTION_KEY,
|
|
mutate: NOOP_MUTATE,
|
|
debounceMs: 0,
|
|
resyncKeys: () => NO_KEYS,
|
|
resolveInvalidation: forward,
|
|
fallbackSubscribe: () =>
|
|
subscribeToSharedEventSource<EventPayload>({
|
|
subscriptions,
|
|
subscriptionKey: SUBSCRIPTION_KEY,
|
|
url: queryKeys.system.attachUrl(),
|
|
mutate: NOOP_MUTATE,
|
|
eventSourceFactory,
|
|
debounceMs: 0,
|
|
resolveInvalidation: forward,
|
|
}),
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Synchronizes React with the shared live-events SSE stream. The subscription is
|
|
* closed before resubscribe and on unmount; `onItem` sees the latest render.
|
|
*/
|
|
export function useLiveEventsSubscription(
|
|
onItem: (item: RunStreamItem) => void,
|
|
) {
|
|
const onItemRef = useRef(onItem);
|
|
onItemRef.current = onItem;
|
|
|
|
useEffect(() => {
|
|
return subscribeToLiveEvents((item) => onItemRef.current(item));
|
|
}, []);
|
|
}
|