mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-11-17 09:31:45 +00:00
Step 4 of the legacy executor deletion, third commit: the legacy event
API and every reader of it go, so that the next commits can delete the
event log, its reducer and the types beneath them.
The API:
- `GET /runs/{id}/events` pages the run stream only
(`PaginatedRunStreamList` by `after`); the legacy `since_seq`,
`before_seq` and `order` cursors, the `oneOf` envelope, the legacy
`EventEnvelope`, `PaginatedEventList`, `RunEvent`, `EventSeq`,
`AppendEventResponse` and `RunEventDetailResponse` schemas,
`POST /runs/{id}/events`, `GET /runs/{id}/events/{seq}` and
`GET /runs/{id}/stages/{stageId}/events` are deleted. `GET
/runs/{id}/attach` and `GET /attach` frame `RunStreamItem`s only.
- The Rust and TypeScript clients regenerate; the removed models leave
the TypeScript package.
The readers:
- `fabro-client` drops the legacy run event listing, tail and attach
methods and `RunEventStream`; `list_run_stream_until` bounds a stream
read.
- `fabro-tool`'s `fabro_run_events` lists, searches and details the run
stream: `after` is the exclusive `stream_seq` cursor, `event_id` the
item's id, filters match the item's name and `recorded_at`.
- `fabro-dump` writes the stream to `events.jsonl`; `fabro dump` reads
it.
- The CLI's progress renderer keeps only what the run stream drives:
the legacy event conversion, the sandbox and setup displays and their
styles go. `fabro system events` prints stream items.
- The server's demo mode folds its agent fixture straight into the
session projection and answers the attach stub with a stream item;
the demo stage events endpoint is gone.
- The web app: every run is a Petri run. The legacy event hooks,
renderer props, stage popover summary, run phases derivation and
live-event payload handling are deleted or ported to `RunStreamItem`;
toasts and board refreshes read the stream's platform records.
- Tests: the legacy API round trips and pagination tests are deleted;
the CLI's MCP, attach and system event mocks serve stream pages; the
CLI test helpers read stream items.
Still failing until the later commits: the CLI tests seeded through
`POST /runs/{id}/events`, the server tests over the legacy store, and
the legacy type tests.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
51 lines
1.9 KiB
TypeScript
51 lines
1.9 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
|
|
import { makePetriItem, makePlatformItem } from "../lib/test-utils";
|
|
import { steeringToastMessage } from "./use-run-toasts";
|
|
|
|
const stage = { name: "code" };
|
|
|
|
function control(seq: number, ctl: Record<string, unknown>, deliverable?: boolean) {
|
|
return makePetriItem(
|
|
seq,
|
|
{ event: "control.requested", firing: 1, ctl },
|
|
{ stage, derived: deliverable === undefined ? undefined : { deliverable } },
|
|
);
|
|
}
|
|
|
|
describe("steeringToastMessage", () => {
|
|
test("a delivered steer, a queued steer and an interrupt each earn a toast", () => {
|
|
expect(steeringToastMessage(control(1, { deliver: { $steer: "try again" } }, true))).toBe(
|
|
"Steer delivered.",
|
|
);
|
|
expect(steeringToastMessage(control(2, { deliver: { $steer: "try again" } }, false))).toBe(
|
|
"Steer queued — will apply when an agent stage runs.",
|
|
);
|
|
expect(steeringToastMessage(control(3, { cancel: { reason: "interrupt" } }))).toBe(
|
|
"Agent interrupted.",
|
|
);
|
|
});
|
|
|
|
test("a refused steer shows the worker's notice", () => {
|
|
expect(
|
|
steeringToastMessage(
|
|
makePlatformItem(4, {
|
|
kind: "run.notice",
|
|
code: "steer_refused",
|
|
message: "No agent stage is running.",
|
|
}),
|
|
),
|
|
).toBe("No agent stage is running.");
|
|
});
|
|
|
|
test("an answer delivery and every other item earn none", () => {
|
|
expect(
|
|
steeringToastMessage(control(5, { deliver: { $answer: { question: "gate#2", choice: "N" } } }, true)),
|
|
).toBeNull();
|
|
expect(steeringToastMessage(makePetriItem(6, { event: "step.finished", firing: 1 }, { stage }))).toBeNull();
|
|
expect(
|
|
steeringToastMessage(makePlatformItem(7, { kind: "run.notice", code: "other", message: "x" })),
|
|
).toBeNull();
|
|
expect(steeringToastMessage(makePlatformItem(8, { kind: "run.lifecycle", transition: "running" }))).toBeNull();
|
|
});
|
|
});
|